address cpplit and gcc warnings.

[fujitatomoya]

fix cpplit and gcc warnings introduced by #178

see CI failures and warnings for https://ci.ros2.org/job/ci_linux/23077/

[fujitatomoya]

Pulls: #184
Gist: https://gist.githubusercontent.com/fujitatomoya/66c2fbe049be48d7003d1654bb6502aa/raw/fed275cc49e07a284ca29b39f94664b7c1503cd8/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15627

• Linux
• Linux-aarch64 (supposed to fail)
• Linux-rhel
• Windows

[fujitatomoya]

i can reproduce cpplint error, and this PR fixes it.

[fujitatomoya]

CI failures are known zenoh related issues, and unrelated warnings for rviz.

Important

DO NOT MERGE THIS, SINCE WE ARE ON API/ABI FREEZE FOR KILTED KAIJU

[christophebedard]

We could probably merge this even with the rmw freeze, since this fixes a warning/test failure in CI.

[cottsay]

We could probably merge this even with the rmw freeze, since this fixes a warning/test failure in CI.

Agreed, let's get some fresh CI to have more confidence that this won't regress and get it in. We'd immediately backport it into Kilted after release anyway, might as well save ourselves the effort.

[christophebedard]

Pulls: #184
Gist: https://gist.githubusercontent.com/christophebedard/54434c3d5da6821d06a8b81300a2c7e9/raw/fed275cc49e07a284ca29b39f94664b7c1503cd8/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15713

• Linux
• Linux-aarch64
• Linux-rhel
• Windows