Skip to content

Remove deprecated GraphCache methods without type hash #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahcorde merged 1 commit into from
Sep 30, 2025
+0 −99
Merged

Remove deprecated GraphCache methods without type hash #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions rmw_dds_common/include/rmw_dds_common/graph_cache.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,21 +99,6 @@ class GraphCache
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos);

/// Add a data writer based on discovery.
/**
* See add_reader with rosidl_type_hash_t, whose other parameters match these.
*/
RMW_DDS_COMMON_PUBLIC
RCUTILS_DEPRECATED_WITH_MSG(
"Migrate to using the version of this function taking a type hash.")
bool
add_writer(
const rmw_gid_t & writer_gid,
const std::string & topic_name,
const std::string & type_name,
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos);

/// Add a data reader based on discovery.
/**
* \param reader_gid GUID of the The data reader.
Expand All @@ -135,21 +120,6 @@ class GraphCache
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos);

/// Add a data reader based on discovery.
/**
* See add_reader with rosidl_type_hash_t, whose other parameters match these.
*/
RMW_DDS_COMMON_PUBLIC
RCUTILS_DEPRECATED_WITH_MSG(
"Migrate to using the version of this function taking a type hash.")
bool
add_reader(
const rmw_gid_t & reader_gid,
const std::string & topic_name,
const std::string & type_name,
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos);

/// Add a data reader or writer.
/**
* \param gid GUID of the entity.
Expand All @@ -173,22 +143,6 @@ class GraphCache
const rmw_qos_profile_t & qos,
bool is_reader);

/// Add a data reader or writer.
/**
* See add_entity with rosidl_type_hash_t, whose other parameters match these.
*/
RMW_DDS_COMMON_PUBLIC
RCUTILS_DEPRECATED_WITH_MSG(
"Migrate to using the version of this function taking a type hash.")
bool
add_entity(
const rmw_gid_t & gid,
const std::string & topic_name,
const std::string & type_name,
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos,
bool is_reader);

/// Remove a data writer.
/**
* \param gid GUID of the data writer.
Expand Down
53 changes: 0 additions & 53 deletions rmw_dds_common/src/graph_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,23 +80,6 @@ GraphCache::add_writer(
return pair.second;
}

bool
GraphCache::add_writer(
const rmw_gid_t & gid,
const std::string & topic_name,
const std::string & type_name,
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos)
{
return this->add_writer(
gid,
topic_name,
type_name,
rosidl_get_zero_initialized_type_hash(),
participant_gid,
qos);
}

bool
GraphCache::add_reader(
const rmw_gid_t & gid,
Expand All @@ -115,23 +98,6 @@ GraphCache::add_reader(
return pair.second;
}

bool
GraphCache::add_reader(
const rmw_gid_t & gid,
const std::string & topic_name,
const std::string & type_name,
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos)
{
return this->add_reader(
gid,
topic_name,
type_name,
rosidl_get_zero_initialized_type_hash(),
participant_gid,
qos);
}

bool
GraphCache::add_entity(
const rmw_gid_t & gid,
Expand Down Expand Up @@ -160,25 +126,6 @@ GraphCache::add_entity(
qos);
}

bool
GraphCache::add_entity(
const rmw_gid_t & gid,
const std::string & topic_name,
const std::string & type_name,
const rmw_gid_t & participant_gid,
const rmw_qos_profile_t & qos,
bool is_reader)
{
return this->add_entity(
gid,
topic_name,
type_name,
rosidl_get_zero_initialized_type_hash(),
participant_gid,
qos,
is_reader);
}

bool
GraphCache::remove_writer(const rmw_gid_t & gid)
{
Expand Down