Allow null arguments in the EventsExecutor parameters (Humble backport)#605
Merged
clalancette merged 1 commit intohumblefrom Jun 2, 2022
Merged
Allow null arguments in the EventsExecutor parameters (Humble backport)#605clalancette merged 1 commit intohumblefrom
clalancette merged 1 commit intohumblefrom
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Contributor
|
@j-rivero Are you backporting the last three commits on master, right? Maybe the PR title should better reflect that, "Add EventsExecutor API for dynamic_fastrtps" as in the initial PR? |
Blast545
approved these changes
May 11, 2022
Contributor
|
Full Humble CI, re running, forgot to include fastrtps-dynamic:
|
clalancette
approved these changes
Jun 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #600