Handle special case of std::vector<bool>#411
Open
oKermorgant wants to merge 2 commits intoros2:masterfrom
Open
Handle special case of std::vector<bool>#411oKermorgant wants to merge 2 commits intoros2:masterfrom
oKermorgant wants to merge 2 commits intoros2:masterfrom
Conversation
Contributor
|
@oKermorgant You probably should signoff on your commits: https://github.com/ros2/ros1_bridge/pull/411/checks?check_run_id=14855763467 |
Signed-off-by: Olivier Kermorgant <olivier_kermorgant@yahoo.fr>
Signed-off-by: Olivier Kermorgant <olivier_kermorgant@yahoo.fr>
Author
|
The last push is to handle |
Member
|
fixes the bool list issue for me 👍 (setup: Ubuntu 24.04, ROS 2 Jazzy / ROS Noetic) Thanks @oKermorgant ! |
|
build fine for me as well, thanks @oKermorgant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the
interface_factoriestemplate file and adds a special case to handle fields which arestd:vector<bool>.The current approach to stream a
std::vectoris tomemcpyits content into/from the stream.Unfortunately, it does not work for
std::vector<bool>as there is not a singleboolinside such.In this PR the template file generates a special call when a
vector<bool>is detected.This should answer #391, #393