[service introspection] add syntactic sugar for recording services#1063
Closed
[service introspection] add syntactic sugar for recording services#1063
Conversation
ihasdapie
requested review from
emersonknapp and
jhdcs
and removed request for
a team
14 tasks
jhdcs
requested changes
Aug 10, 2022
Contributor
jhdcs
left a comment
jhdcs
left a comment
There was a problem hiding this comment.
Just a mild code format issue that's annoying the tests. Apart from that, this looks good to me!
jhdcs
approved these changes
Aug 10, 2022
Member
Author
|
I'm just going to turn this into a draft PR for now so that this doesn't get merged in by accident before the ones it depends on gets merged in (Full list @ ros2/ros2#1285 (comment)) |
Contributor
|
I just missed - it looks like you haven't signed a commit somewhere... I think it might be your initial commit. Would you be able to sign that? |
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Co-authored-by: jhdcs <48914066+jhdcs@users.noreply.github.com> Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
ihasdapie
force-pushed
the
service_introspection
branch
from
7010eee to
d2eb97f
Compare
Member
Author
|
Ah yeah that would be from when I commited your suggestion from the web client...fixed now |
Closed
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps implements the proposed REP2012 ros-infrastructure/rep#360 and adds a
--serviceor-Soption toros2 bag recordto make it easier to record service eventsRelated issue: ros2/ros2#1285
Signed-off-by: Brian Chen brian.chen@openrobotics.org