Skip to content

Add BagSplitInfo on bag close#1213

Closed
aditya2592 wants to merge 4 commits intoros2:humblefrom
aditya2592:aditya/bag_close_event
Closed

Add BagSplitInfo on bag close#1213
aditya2592 wants to merge 4 commits intoros2:humblefrom
aditya2592:aditya/bag_close_event

Conversation

@aditya2592
Copy link

No description provided.

@MichaelOrlov
Copy link
Contributor

@aditya2592 Please rebase your branch to Rolling.
We need to make new work on Rolling first, then consider backporting it to Humble and Foxy.

@aditya2592
Copy link
Author

Thanks for creating the rolling branch and pushing the commits!. I had created this one to test with our stack which uses Humble and see the diff. Will continue discussion on your new PR

@aditya2592 aditya2592 closed this Dec 19, 2022
@MichaelOrlov
Copy link
Contributor

@aditya2592 My draft PR #1216 only some estimate how implementation could be in relevant parts and the purpose of it was to try to verify implementation with tests on CI.
However some tests fails on reading metada file in place where QoS settings stored. It looks like QoS settings became storing incorrectly. Need investigate those failure.
I am sorry I don't have capacity for this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants