[iron] Add recorder stop() API (backport #1300)#1334
Conversation
* Expose Writer::close() as public API and add Recorder::stop() API Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: aditya <aditya@nimble.ai> * Move routines from recorder's destructor to RecorderImpl::stop() Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add can_record_again_after_stop unit test in rosbag2_transport Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Update Doxygen comments for stop() and pause() API in recorder.hpp Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: aditya <aditya@nimble.ai> (cherry picked from commit a218e37)
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/ec3532e44fbd21961822e268e61c5694/raw/b6678a24315515c1ea0a339873910a8168920912/ros2.repos |
|
@clalancette I want to merge this PR to the iron branch. |
That's fine, we still have about 2 days to get these kind of changes in. |
|
@clalancette The same question here. Do you have any idea why so many test failures in |
|
@ros-pull-request-builder retest this please |
|
@clalancette It seems it was some intermittent problem in CI infrastructure. After retesting I am re-running the Windows CI job since it failed in some unrelated tests. Error message from previous CI run on Windows for reference. |
This is an automatic backport of pull request #1300 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com