[humble] Add recorder stop() API (backport #1300)#1396
Merged
emersonknapp merged 1 commit intohumblefrom Jun 13, 2023
Merged
Conversation
- Add Recorder::stop() API - Move routines from recorder's destructor to RecorderImpl::stop() - Add can_record_again_after_stop unit test in rosbag2_transport - Update Doxygen comments for stop() and pause() API in recorder.hpp Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov
force-pushed
the
morlov/backport_recorder_stop_to_humble
branch
from
02438aa to
4e429d8
Compare
Contributor
Author
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/985f7d2d3934588c7e6b3c359e32b6c6/raw/571985b79a6b78718f87c1b61515f72b470aa4e6/ros2.repos
|
This was referenced Jun 13, 2023
emersonknapp
approved these changes
Jun 13, 2023
delete-merged-branch
bot
deleted the
morlov/backport_recorder_stop_to_humble
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writer::close()API has already been backported in the [humble] Backport close() to rosbag2_cpp::writer to humble #1363Note: Adding a new non-virtual method is not a breaking API ABI change according to the https://www.acodersjourney.com/20-abi-breaking-changes/