[iron] Add BagSplitInfo service call on bag close (backport #1422)#1636
[iron] Add BagSplitInfo service call on bag close (backport #1422)#1636MichaelOrlov merged 1 commit intoironfrom
Conversation
- Note: The `BagSplitInfo::opened_file` will have empty string to indicate that it was "bag close" and not bag split event. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> (cherry picked from commit ba199d0)
MichaelOrlov
left a comment
There was a problem hiding this comment.
Note: In this PR we are adding a new public method to the EventCallbackManager.
However, this is ABI compatible changes according to the https://acodersjourney.com/20-abi-breaking-changes/
- Add new non-virtual methods to an existing class
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/20516443e02fa9ea05ae60f71b4f54dc/raw/1a8e502306882e59e6eb65f7ece4573d567bd913/ros2.repos |
|
@clalancette The Iron CI fails with bunch of violations in uncrustify and flake8 https://ci.ros2.org/job/ci_linux-aarch64/15295/#showFailuresLink. |
It was not updated; the CI was run against |
|
As regards:
Good catch. Interesting. Will need to check |
BagSplitInfo::opened_filewill have an empty string to indicate that it was "bag close" and not bag split event.This is an automatic backport of pull request Add BagSplitInfo service call on bag close #1422 done by Mergify.