Skip to content

[iron] Add BagSplitInfo service call on bag close (backport #1422)#1636

Merged
MichaelOrlov merged 1 commit intoironfrom
mergify/bp/iron/pr-1422
May 6, 2024
Merged

[iron] Add BagSplitInfo service call on bag close (backport #1422)#1636
MichaelOrlov merged 1 commit intoironfrom
mergify/bp/iron/pr-1422

Conversation

@mergify
Copy link

@mergify mergify bot commented May 6, 2024

- Note: The `BagSplitInfo::opened_file` will have empty string to
indicate that it was "bag close" and not bag split event.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit ba199d0)
@mergify mergify bot requested a review from a team as a code owner May 6, 2024 05:32
@mergify mergify bot requested review from MichaelOrlov and james-rms and removed request for a team May 6, 2024 05:32
@MichaelOrlov MichaelOrlov changed the title Add BagSplitInfo service call on bag close (backport #1422) [iron] Add BagSplitInfo service call on bag close (backport #1422) May 6, 2024
Copy link
Contributor

@MichaelOrlov MichaelOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: In this PR we are adding a new public method to the EventCallbackManager.
However, this is ABI compatible changes according to the https://acodersjourney.com/20-abi-breaking-changes/

  1. Add new non-virtual methods to an existing class

@MichaelOrlov
Copy link
Contributor

Gist: https://gist.githubusercontent.com/MichaelOrlov/20516443e02fa9ea05ae60f71b4f54dc/raw/1a8e502306882e59e6eb65f7ece4573d567bd913/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_transport ros2bag
TEST args: --packages-above rosbag2_cpp rosbag2_transport ros2bag
ROS Distro: iron
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/13816

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Contributor

MichaelOrlov commented May 6, 2024

@clalancette The Iron CI fails with bunch of violations in uncrustify and flake8 https://ci.ros2.org/job/ci_linux-aarch64/15295/#showFailuresLink.
It seems uncrustify was updated on the Iron which is not expected to be.
Should I fix all violations in rosbag2 or it is gonna be some more generic remedy by pinning uncrustify?

@clalancette
Copy link
Contributor

It seems uncrustify was updated on the Iron which is not expected to be.

It was not updated; the CI was run against noble. Fixing that to jammy should fix the CI.

@MichaelOrlov
Copy link
Contributor

As regards:

CI was run against noble. Fixing that to jammy should fix the CI.

Good catch. Interesting. Will need to check ros-ci-for-pr scripts if we need to update it.

@MichaelOrlov
Copy link
Contributor

Re-run Linux CI jobs with "jammy" linux distro

  • Linux Build Status
  • Linux-aarch64 Build Status

@MichaelOrlov MichaelOrlov merged commit 809ca5a into iron May 6, 2024
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/iron/pr-1422 branch May 6, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants