[jazzy] doc: readme: fix example conversion configs: all -> all_topics (backport #1661)#1668
Merged
MichaelOrlov merged 1 commit intojazzyfrom May 21, 2024
Merged
Conversation
* fix example conversion configs: all -> all_topics Signed-off-by: Jonas Otto <jonas@jonasotto.com> * update topic and service selection arguments in conversion config in readme Signed-off-by: Jonas Otto <jonas@jonasotto.com> * add all_services: true to first example Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Jonas Otto <jonas@jonasotto.com> * add all_services: true to second example Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Jonas Otto <jonas@jonasotto.com> --------- Signed-off-by: Jonas Otto <jonas@jonasotto.com> Co-authored-by: Michael Orlov <morlovmr@gmail.com> (cherry picked from commit 938fafa)
mergify
bot
requested review from
MichaelOrlov and
jhdcs
and removed request for
a team
MichaelOrlov
changed the title
MichaelOrlov
approved these changes
May 21, 2024
Contributor
|
@clalancette I am asking for confirmation that we can merge this backport to Jazzy without running CI and before release. |
clalancette
approved these changes
May 21, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Yes, this one is fine to merge because it is only documentation. @marcoag FYI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was changed in #1480, see issue #1660
This is an automatic backport of pull request #1661 done by Mergify.