[Design] Add design doc for actions recording and replay#1928
Conversation
Barry-Xu-2018
deleted the
review/topic-add-design-for-record-replay-action
branch
Barry-Xu-2018
restored the
review/topic-add-design-for-record-replay-action
branch
|
@MichaelOrlov we would really like to have some help here 🙇 could you take a look at the design overview about |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
force-pushed
the
review/topic-add-design-for-record-replay-action
branch
from
b5ab653 to
d8246df
Compare
MichaelOrlov
left a comment
MichaelOrlov
left a comment
There was a problem hiding this comment.
@fujitatomoya @Barry-Xu-2018 Thank you for the design document. Overall seems good. I found a few nitpicks and one major proposal.
I would reverse the logic for the --send-action-goal parameter and send by default the real action's service requests instead of the recorded service events. As far as I understand, this would be a desired behavior in most cases.
I also found that --send-action-goal is unclear about what it really means and difficult to clarify nuances in the comments.
Barry-Xu-2018
left a comment
Barry-Xu-2018
left a comment
There was a problem hiding this comment.
Thank you for your review. Let's discuss some of the comments further.
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
Signed-off-by: Barry Xu <barry.xu@sony.com>
|
I update design 437e784. |
Signed-off-by: Barry Xu <barry.xu@sony.com>
MichaelOrlov
changed the title
|
@MichaelOrlov @Barry-Xu-2018 as always, thanks for putting your effort! appreciate it. we still have big one 😅 #1939 that i will take a look, and... playback is coming after this, right @Barry-Xu-2018 ? |
3 participants
The design for recording and replay action.