Add design document: Support repeating transient-local (“latched”) messages in Rosbag2 recorder#2327
Add design document: Support repeating transient-local (“latched”) messages in Rosbag2 recorder#2327MichaelOrlov wants to merge 2 commits intorollingfrom
Conversation
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
force-pushed
the
morlov/repeat-transient-local-msgs-design
branch
from
59155e3 to
5b3ec91
Compare
MichaelOrlov
requested review from
Barry-Xu-2018,
christophebedard,
emersonknapp and
fujitatomoya
|
|
||
| ## Open questions | ||
|
|
||
| 1. Should we use `--repeat-tl` or `--repeat-transient-local` or `--repeat-latched` for the CLI |
There was a problem hiding this comment.
I'd probably prefer --repeat-transient-local just because I don't think tl is intuitive for transient local
There was a problem hiding this comment.
On the one hand, I like --repeat-transient-local for its fullness and clear description. However, on the other hand, it is too long, especially if used in combination with other CLI arguments and a list of topics.
I don't have a strong opinion on this naming and would be happy to hear more opinions.
| familiarity and clarity while keeping the CLI concise. | ||
|
|
||
| 2. Should we support regex patterns in `--repeat-tl` (e.g., `/tf_*`)? | ||
| - Deferred to future work based on user feedback |
There was a problem hiding this comment.
Deferred to future work based on user feedback
clear trace of AI here, maybe reformulate
tonynajjar
left a comment
tonynajjar
left a comment
There was a problem hiding this comment.
In general looks good. My PR goes in that direction but of course doesn't completely align with all the points of this design documents - can be a good starting point.
@MichaelOrlov after this is merged do you plan on making the implementation?
|
Hi, would it be possible to address this issue #2333 as well please? Related to latched topics and would be extremely useful. |
Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
changed the title
3 participants
Description
Add design document: Support repeating transient-local (“latched”) messages in Rosbag2 recorder.
--repeat-latchedin ROS 2 (transient local) #1159Is this user-facing behavior change?
No.
Did you use Generative AI?
Ye. GitHub Copilot, GPT-5.0 and ClaudeCode 4.5
Additional Information
N/A