Surpressing multi-threaded process warning from rosbag2 flake8.#2329
Open
fujitatomoya wants to merge 2 commits intorollingfrom
Open
Surpressing multi-threaded process warning from rosbag2 flake8.#2329fujitatomoya wants to merge 2 commits intorollingfrom
fujitatomoya wants to merge 2 commits intorollingfrom
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
There was a problem hiding this comment.
Pull request overview
This PR updates ros2bag’s pytest configuration to eliminate noisy warnings during the flake8 test run (notably the “multi-threaded, use of fork() may lead to deadlocks” warning observed under Python 3.12/Ubuntu 22.04).
Changes:
- Adds pytest-timeout configuration (900s per-test timeout, thread-based timeout method).
- Converts
filterwarningsto a multi-line list and adds a filter to suppress the fork-in-multithreaded-process warning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Contributor
Author
|
Pulls: #2329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
No
Additional Information
https://github.com/ros2/sros2/blob/rolling/sros2/pytest.ini, we have done the same thing to sros2.