[draft] Add on start recording callback for Recorder#2340
Draft
MichaelOrlov wants to merge 1 commit intorollingfrom
Draft
[draft] Add on start recording callback for Recorder#2340MichaelOrlov wants to merge 1 commit intorollingfrom
MichaelOrlov wants to merge 1 commit intorollingfrom
Conversation
- Sets the callback to be invoked when recording is started. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new public API set_on_start_recording_callback() to the
rosbag2_transport::Recorderclass, which sets the callback to be invoked when recording is started.Motivation:
We need to know on a C++ layer when
rosbag2_transport::Recorderstarts recording is triggered via a service call or possibly by other means (from another thread).Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
Can be backported.