Common: rewrite check_transfer_queue_status

[voetberg]

• Rewrite base query with sqla2.0
• Move CASE statements into python logic - This I am less confident I got it correct, I could not figure out exactly what the external_host is supposed to look like. The probe has been broken a long time in CMS int and prod so I'm missing some reference material there.
• Sort Imports
• Update header
• Update exception statement
• Change gauge to PrometheusPusher

[dchristidis]

Nicely done. I’m happy on my end.

[dchristidis]

I‘m afraid I have to withdraw my approval.

There is a significant change that was not mentioned at all in the commit: the metric name has been changed from conveyor_queues_requests to rucio_probes_transfer. Also state now contains the queues.requests. prefix, which doesn’t look right to me.

Similarly, the other two PRs I approved will have to be revisited.

[voetberg]

There is a significant change that was not mentioned at all in the commit: the metric name has been changed from conveyor_queues_requests to rucio_probes_transfer.

I think the Prometheus pusher automatically appends rucio_probes, but otherwise I can swap the transfer part of the label back.

Also state now contains the queues.requests. prefix, which doesn’t look right to me.

That was from the original query (unless I missed a post-processing step in the original? That case statement just makes my head spin so it's a possibility)

[ericvaandering]

Correct. "rucio_probes" (or "rucio.probes" for Graphite) is added by the pusher

probes/common/utils/common.py

Line 17 in a7c0556

PROBES_PREFIX = 'rucio.probes'

I'm going to approve this.

[voetberg]

Closing in favor of #161