Refactor of experimental config aka config+#553
Draft
sourishkrout wants to merge 4 commits intomainfrom
Draft
Conversation
sourishkrout
force-pushed
the
seb-config-plus
branch
from
a1842b3 to
569a9f8
Compare
|
sourishkrout
pushed a commit
that referenced
this pull request
May 23, 2024
Contributor
Author
|
Obsolete due to #584. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopped short of aligning the internal implementations naming/shape yet until we get from
alphato something likebeta.The idea was to separate configuration concerns by
Kernel(anything that's core and settings that are shared between clients; still need to pull them in from primarily the extension) andProjectwhich describes how to handle the project inside repo the config resides in.What I still need to add is
Documentaka Frontmatter which is either meant to be set globally at root or allows overwrites via nesting per directory (e.g.cwd: ../..).Post PR early to allow work in progress feedback.