Skip to content

Comments

Separate project and runtime options in runme.yaml#584

Merged
sourishkrout merged 1 commit intoadamb/runme-yaml-remove-kernelfrom
adamb/re-apply-config-plus
May 23, 2024
Merged

Separate project and runtime options in runme.yaml#584
sourishkrout merged 1 commit intoadamb/runme-yaml-remove-kernelfrom
adamb/re-apply-config-plus

Conversation

@adambabik
Copy link
Collaborator

Replaces #553

@adambabik adambabik force-pushed the adamb/re-apply-config-plus branch from 7d44cbc to 4961a6b Compare May 22, 2024 21:54
@sonarqubecloud
Copy link

@adambabik adambabik changed the base branch from main to adamb/runme-yaml-remove-kernel May 23, 2024 18:13
@adambabik adambabik marked this pull request as ready for review May 23, 2024 18:13
@adambabik adambabik requested a review from sourishkrout May 23, 2024 18:13
Copy link
Contributor

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. It does not include the notion of kernel which wasn't was runtime is now but it's much closer. So let's roll with it for the time being.

@sourishkrout sourishkrout merged commit 6af9581 into adamb/runme-yaml-remove-kernel May 23, 2024
@sourishkrout sourishkrout deleted the adamb/re-apply-config-plus branch May 23, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants