Skip to content

Comments

Devel#10

Merged
sailingpalmtree merged 20 commits intomasterfrom
devel
Jul 9, 2025
Merged

Devel#10
sailingpalmtree merged 20 commits intomasterfrom
devel

Conversation

@sailingpalmtree
Copy link
Owner

No description provided.

flake8-codes \
flake8-import-order
flake8==4.0.1 \
pylint>=2.15.0 \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [hadolint] <SC2261> reported by reviewdog 🐶
Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.

@sailingpalmtree sailingpalmtree self-assigned this Jul 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR removes an unused environment variable, comments out a problematic pip upgrade step, and pins linting tool versions in both Dockerfiles for stability.

  • Remove obsolete INPUT_FILTER_MODE export from the entrypoint.
  • Comment out the Python pip upgrade due to a broken /usr/bin/pip reference.
  • Pin specific versions of flake8, pylint, flakeheaven, and related plugins.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
entrypoint.sh Removed INPUT_FILTER_MODE export
Dockerfile.testing Commented out pip upgrade; added version pins
Dockerfile Commented out pip upgrade; added version pins
Comments suppressed due to low confidence (3)

entrypoint.sh:10

  • [nitpick] If INPUT_FILTER_MODE is no longer required, consider adding a brief comment explaining its removal or fully deleting the dead code to avoid confusion.
export PY_EXE="${INPUT_PYTHON_VERSION}"

Dockerfile.testing:45

  • The version specifier includes a leading 'v'. Pip expects numeric versions, so this should be flake8-markdown>=0.3.0.
    flake8-markdown>=v0.3.0 \

Dockerfile:45

  • The version specifier includes a leading 'v'. Pip expects numeric versions, so this should be flake8-markdown>=0.3.0.
    flake8-markdown>=v0.3.0 \

@sailingpalmtree sailingpalmtree merged commit 0433cd4 into master Jul 9, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants