Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3079c53
First copy of the reviewdog-flakehell-action, which is already using …
Jul 20, 2022
45ff4cb
Remove the unused env var.
Jul 20, 2022
bba3d94
Add my flakehell plugin's README to they can be merged.
Jul 20, 2022
35324b0
Merge branch 'master' into devel
Jul 20, 2022
ce7fb21
Add pyproject.toml.
Jul 20, 2022
1f52553
Update old README to almost being complete.
Jul 20, 2022
c0922a1
More README updates from the unsaved file, thanks vscode.
sailingpalmtree Jul 20, 2022
9e3e084
Promote the README to the main page, save the one from reviewdog.
sailingpalmtree Jul 20, 2022
f09fd76
Update GH action runner names for the test workflow.
sailingpalmtree Jul 20, 2022
41815aa
Update action's name so it's unique and can be published.
sailingpalmtree Jul 21, 2022
29d8679
Better flakeheaven config.
sailingpalmtree Jul 21, 2022
e199ae4
Merge branch 'master' into devel
sailingpalmtree Jul 21, 2022
a6ae6a9
Remove inherited README.
sailingpalmtree Jul 21, 2022
d4259a1
Merge branch 'devel' of https://github.com/sailingpalmtree/lint into …
sailingpalmtree Jul 21, 2022
87da874
Pin flake8-simplify version to avoid pip having to look through all o…
balint-bg Aug 3, 2022
3ac6953
Merge branch 'master' into devel
balint-bg Aug 3, 2022
253b645
Pin all plugin versions.
balint-bg Aug 3, 2022
a406b0f
Comment out pip upgrade, seems to break things.
balint-bg Aug 3, 2022
d62e5b8
Pin flake8 version, 5.0.0> isn't compatible with flakeheaven...
balint-bg Aug 3, 2022
95a365f
Dont default to diff context only (#9)
sailingpalmtree Jul 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,30 +21,31 @@ RUN add-apt-repository ppa:deadsnakes/ppa -y
RUN apt-get update && apt-get install -y --no-install-recommends \
${PYTHON_VERSION} \
python3-pip
RUN ${PYTHON_VERSION} -m pip install --no-cache-dir --upgrade pip
# TODO(balint) this seems to break later pip commands: "/usr/bin/pip not found"
# RUN ${PYTHON_VERSION} -m pip install --no-cache-dir --upgrade pip
RUN apt-get update && apt-get install -y --no-install-recommends \
python3-distutils \
python3-setuptools

# Clean up apt-get
RUN apt-get clean && rm -rf /var/lib/apt/lists/*

# Install reviewdog, flake8, pylint and flakeheaven, then plugins for flakeheaven
# Install flake8, pylint and flakeheaven, then plugins for flakeheaven
RUN ${PYTHON_VERSION} -m pip install --no-cache-dir \
flake8 \
flakeheaven \
pylint \
flake8-bugbear \
flake8-comprehensions \
flake8-return \
flake8-simplify \
flake8-spellcheck \
flake8-functions \
wemake-python-styleguide \
flake8-markdown \
flake8-docstrings \
flake8-codes \
flake8-import-order
flake8==4.0.1 \
pylint>=2.15.0 \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [hadolint] <SC2261> reported by reviewdog 🐶
Multiple redirections compete for stdout. Use cat, tee, or pass filenames instead.

flakeheaven>=3.0.0 \
flake8-bugbear>=22.7.1 \
flake8-comprehensions>=3.10.0 \
flake8-return>=1.1.3 \
flake8-simplify>=0.19.3 \
flake8-spellcheck>=0.28.0 \
flake8-functions>=0.0.7 \
wemake-python-styleguide>=0.16.1 \
flake8-markdown>=v0.3.0 \
flake8-docstrings>=1.6.0 \
flake8-codes>=0.2.2 \
flake8-import-order>=0.18.1

SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh \
Expand Down
35 changes: 18 additions & 17 deletions Dockerfile.testing
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,32 @@ RUN add-apt-repository ppa:deadsnakes/ppa -y
RUN apt-get update && apt-get install -y --no-install-recommends \
${PYTHON_VERSION} \
python3-pip
RUN ${PYTHON_VERSION} -m pip install --no-cache-dir --upgrade pip
# TODO(balint) this seems to break later pip commands: "/usr/bin/pip not found"
# RUN ${PYTHON_VERSION} -m pip install --no-cache-dir --upgrade pip
RUN apt-get update && apt-get install -y --no-install-recommends \
python3-distutils \
python3-setuptools

# Clean up apt-get
RUN apt-get clean && rm -rf /var/lib/apt/lists/*

# Install reviewdog, flake8, pylint and flakeheaven, then plugins for flakeheaven

# Install flake8, pylint and flakeheaven, then plugins for flakeheaven
RUN ${PYTHON_VERSION} -m pip install --no-cache-dir \
flake8 \
flakeheaven \
pylint \
flake8-bugbear \
flake8-comprehensions \
flake8-return \
flake8-simplify \
flake8-spellcheck \
flake8-functions \
wemake-python-styleguide \
flake8-markdown \
flake8-docstrings \
flake8-codes \
flake8-import-order
flake8==4.0.1 \
pylint>=2.15.0 \
flakeheaven>=3.0.0 \
flake8-bugbear>=22.7.1 \
flake8-comprehensions>=3.10.0 \
flake8-return>=1.1.3 \
flake8-simplify>=0.19.3 \
flake8-spellcheck>=0.28.0 \
flake8-functions>=0.0.7 \
wemake-python-styleguide>=0.16.1 \
flake8-markdown>=v0.3.0 \
flake8-docstrings>=1.6.0 \
flake8-codes>=0.2.2 \
flake8-import-order>=0.18.1


SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh \
Expand Down
1 change: 0 additions & 1 deletion entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ if [ -n "${GITHUB_WORKSPACE}" ]; then
fi

export PY_EXE="${INPUT_PYTHON_VERSION}"
export INPUT_FILTER_MODE=diff_context
export REVIEWDOG_GITHUB_API_TOKEN="${INPUT_GITHUB_TOKEN}"
TMPFILE=$(mktemp)
export TMPFILE
Expand Down
Loading