[dev] Hide Hashie Mash key-conflict warnings#2330
[dev] Hide Hashie Mash key-conflict warnings#2330StephenHulme wants to merge 1 commit intodevelopfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2330 +/- ##
========================================
Coverage 81.25% 81.25%
========================================
Files 478 478
Lines 18511 18511
Branches 278 278
========================================
Hits 15041 15041
Misses 3468 3468
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenTopping
left a comment
There was a problem hiding this comment.
Looks like we are only using Hashie::Mash here. Wondering if there is a replacement for it in vanilla ruby / rails and we can remove it entirely?
That would be lovely. Unfortunately there doesn't seem to be a drop-in replacement, but I think we should be using strongly-typed config, rather than a very lenient hash structure. https://dry-rb.org/gems/dry-struct/1.6/ looks like a promising direction to go, unless there is something more Railsy. |
Reduces log length and developer frustration.
Changes proposed in this pull request
Implements: https://www.rubydoc.info/gems/hashie/Hashie%2FMash.quiet
min,max,size,classin developer logs.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version