Skip to content

Conversation

@AnnatarHe
Copy link
Contributor

Summary

  • Increase DefaultShineInterval from 32ms to 80ms in stloader/loader.go
  • Makes the loading animation (~12 FPS) more comfortable to watch than the previous ~31 FPS

Test plan

  • Build the CLI: go build -o shelltime ./cmd/cli/main.go
  • Run a query: ./shelltime query "test" and observe the loading animation
  • Verify the shine effect is slower and easier on the eyes

🤖 Generated with Claude Code

Increase DefaultShineInterval from 32ms to 80ms to make the loading
animation more comfortable to watch. The previous 31 FPS was too fast
and caused visual strain.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the user experience of the application's loading animation. By modifying a single configuration value, the animation's speed is reduced, aiming to create a more comfortable and less visually demanding interaction for users during loading states.

Highlights

  • Animation Speed Adjustment: The DefaultShineInterval in stloader/loader.go has been increased from 32ms to 80ms. This change effectively slows down the loading animation's shine effect from approximately 31 frames per second (FPS) to about 12 FPS.
  • Improved User Experience: The primary goal of this adjustment is to enhance user comfort by making the loading animation less jarring and more pleasant to observe, as a slower animation rate is generally easier on the eyes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 37.93% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
stloader/loader.go 93.85% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively improves the user experience by slowing down the shine animation interval. The change is straightforward and well-justified. I have added one comment regarding an outdated code comment that should be updated to maintain code and documentation consistency.

const (
DefaultSpinInterval = 200 * time.Millisecond
DefaultShineInterval = 32 * time.Millisecond
DefaultShineInterval = 80 * time.Millisecond
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've correctly updated the default value, the corresponding comment for ShineInterval in the LoaderConfig struct (on line 36) is now outdated. It still refers to the old default of 32ms.

Please update it to reflect the new default of 80ms to avoid confusion for future developers using this package.

Suggested Change:

// stloader/loader.go:36
// ShineInterval is the time between color sweep updates (default: 80ms)
// stloader/loader.go:36
// ShineInterval is the time between color sweep updates (default: 80ms)

@AnnatarHe AnnatarHe merged commit 284460e into main Jan 10, 2026
5 checks passed
@AnnatarHe AnnatarHe deleted the fix/loader-shine-interval-too-fast branch January 10, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants