-
Notifications
You must be signed in to change notification settings - Fork 0
fix(stloader): slow down shine animation interval for better UX #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Increase DefaultShineInterval from 32ms to 80ms to make the loading animation more comfortable to watch. The previous 31 FPS was too fast and caused visual strain. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @AnnatarHe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the user experience of the application's loading animation. By modifying a single configuration value, the animation's speed is reduced, aiming to create a more comfortable and less visually demanding interaction for users during loading states. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively improves the user experience by slowing down the shine animation interval. The change is straightforward and well-justified. I have added one comment regarding an outdated code comment that should be updated to maintain code and documentation consistency.
| const ( | ||
| DefaultSpinInterval = 200 * time.Millisecond | ||
| DefaultShineInterval = 32 * time.Millisecond | ||
| DefaultShineInterval = 80 * time.Millisecond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you've correctly updated the default value, the corresponding comment for ShineInterval in the LoaderConfig struct (on line 36) is now outdated. It still refers to the old default of 32ms.
Please update it to reflect the new default of 80ms to avoid confusion for future developers using this package.
Suggested Change:
// stloader/loader.go:36
// ShineInterval is the time between color sweep updates (default: 80ms)// stloader/loader.go:36
// ShineInterval is the time between color sweep updates (default: 80ms)
Summary
DefaultShineIntervalfrom 32ms to 80ms instloader/loader.goTest plan
go build -o shelltime ./cmd/cli/main.go./shelltime query "test"and observe the loading animation🤖 Generated with Claude Code