Skip to content

fix(stloader): slow down shine animation interval for better UX #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnnatarHe merged 1 commit into from
Jan 10, 2026
+1 −1
Merged

fix(stloader): slow down shine animation interval for better UX #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stloader/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var DefaultSymbols = []string{"⠋", "⠙", "⠹", "⠸", "⠼", "⠴", "⠦", "
// Default configuration values
const (
DefaultSpinInterval = 200 * time.Millisecond
DefaultShineInterval = 32 * time.Millisecond
DefaultShineInterval = 80 * time.Millisecond
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While you've correctly updated the default value, the corresponding comment for ShineInterval in the LoaderConfig struct (on line 36) is now outdated. It still refers to the old default of 32ms.

Please update it to reflect the new default of 80ms to avoid confusion for future developers using this package.

Suggested Change:

// stloader/loader.go:36
// ShineInterval is the time between color sweep updates (default: 80ms)
// stloader/loader.go:36
// ShineInterval is the time between color sweep updates (default: 80ms)

)

// LoaderConfig holds configuration options for the loader
Expand Down
Loading