Store API data in local storage instead of sync storage.#122
Open
FozzieHi wants to merge 3 commits intosimple-login:masterfrom
Open
Store API data in local storage instead of sync storage.#122FozzieHi wants to merge 3 commits intosimple-login:masterfrom
FozzieHi wants to merge 3 commits intosimple-login:masterfrom
Conversation
Closed
Collaborator
|
@nguyenkims Can you please take a look to see if we can merge? Thank you! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
apiUrlandapiKeyin local storage instead of sync storage. We use a separateTYPESvariable for this instead of makingSETTINGSan object for ease of use when usingSETTINGSkeys.apiUrlorapiKeyvalues in sync storage to local storage and deletes them from sync storage if successful.