Closed
Conversation
Merged
FozzieHi
requested review from
acasajus,
cquintana92 and
nguyenkims
as code owners
Contributor
|
@FozzieHi hey do you know if the code is still compatible with node 16 after this PR is merged? We still use v16 as it's an active LTS version. |
Author
|
@nguyenkims When I last tested it it seemed fine, I used it to develop the PRs I submitted here. However, as it's been since February it's likely the packages in this PR are out of date anyway now. I'd recommend closing this PR and updating the packages now and seeing if it works. |
Contributor
|
@FozzieHi let me close this PR then. When npm 18 is more stable, we can upgrade the package to this version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you cannot install the packages using Node.js v17. To fix this I ran an
npm updateto update packages to their latest pinned versions inpackage.json. Technically as these are minor version bumps there should not be any breaking changes, and through my testing of #122 and #123 I haven't noticed any breakage. However, it may be better to just see what package is causing the issue with installations by going through them one by one.There does seem to be some formatting changes in
prettieras this is the output generated by runningnpm run prettier:writewith this update.