Skip to content

Conversation

@pavel-raykov
Copy link
Contributor

@pavel-raykov pavel-raykov commented Jan 27, 2026

@github-actions
Copy link
Contributor

✅ API Diff Results - No breaking changes


📄 View full apidiff report

@pavel-raykov pavel-raykov marked this pull request as ready for review January 27, 2026 08:48
@pavel-raykov pavel-raykov requested a review from a team as a code owner January 27, 2026 08:48
Copilot AI review requested due to automatic review settings January 27, 2026 08:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the EVM chain reader service from the core chainlink repository into chainlink-evm, supporting a refactoring effort to modularize EVM-specific functionality.

Changes:

  • Introduces a complete ChainReader service implementation for reading EVM contract data
  • Adds comprehensive test coverage for the ChainReader functionality including type handling and binding operations
  • Implements support for methods, events, and various primitive/complex data types

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pkg/read/chain_reader.go Core implementation of the ChainReaderService with support for contract binding, method/event reading, and various query operations
pkg/read/chain_reader_test.go Test suite covering ChainReader functionality including type conversions, binding operations, and integration with LogPoller

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

for genericName, cfgDWDetail := range cfgDWsDetails {
dwDetail, exists := dWsDetail[genericName]
if exists && cfgDWDetail.Index != nil {
return nil, fmt.Errorf("data word: %q at index: %d details, were calculated automatically and shouldn't be manully overridden by cfg", genericName, dwDetail.Index)
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'manully' to 'manually'.

Suggested change
return nil, fmt.Errorf("data word: %q at index: %d details, were calculated automatically and shouldn't be manully overridden by cfg", genericName, dwDetail.Index)
return nil, fmt.Errorf("data word: %q at index: %d details, were calculated automatically and shouldn't be manually overridden by cfg", genericName, dwDetail.Index)

Copilot uses AI. Check for mistakes.
@pavel-raykov pavel-raykov merged commit 21d7db9 into develop Jan 27, 2026
33 checks passed
@pavel-raykov pavel-raykov deleted the move-read2 branch January 27, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants