-
Notifications
You must be signed in to change notification settings - Fork 15
[CRE-491] Move read EVM service from core. #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ API Diff Results - No breaking changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR moves the EVM chain reader service from the core chainlink repository into chainlink-evm, supporting a refactoring effort to modularize EVM-specific functionality.
Changes:
- Introduces a complete ChainReader service implementation for reading EVM contract data
- Adds comprehensive test coverage for the ChainReader functionality including type handling and binding operations
- Implements support for methods, events, and various primitive/complex data types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/read/chain_reader.go | Core implementation of the ChainReaderService with support for contract binding, method/event reading, and various query operations |
| pkg/read/chain_reader_test.go | Test suite covering ChainReader functionality including type conversions, binding operations, and integration with LogPoller |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for genericName, cfgDWDetail := range cfgDWsDetails { | ||
| dwDetail, exists := dWsDetail[genericName] | ||
| if exists && cfgDWDetail.Index != nil { | ||
| return nil, fmt.Errorf("data word: %q at index: %d details, were calculated automatically and shouldn't be manully overridden by cfg", genericName, dwDetail.Index) |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'manully' to 'manually'.
| return nil, fmt.Errorf("data word: %q at index: %d details, were calculated automatically and shouldn't be manully overridden by cfg", genericName, dwDetail.Index) | |
| return nil, fmt.Errorf("data word: %q at index: %d details, were calculated automatically and shouldn't be manually overridden by cfg", genericName, dwDetail.Index) |
Supports smartcontractkit/chainlink#20935