-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[CRE-491] Use moved read EVM service from chainlink-evm #20935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
|
I see you updated files related to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the codebase to use the read.NewChainReaderService function from the chainlink-evm package instead of the previously used evm.NewChainReaderService from the local codebase. The change reflects that the EVM service has been moved to the external chainlink-evm repository.
Changes:
- Updated
chainlink-evmdependency version across all module files - Migrated from local
evm.NewChainReaderServicetochainlink-evm/pkg/read.NewChainReaderService - Removed local chain reader implementation files (
chain_reader.goandchain_reader_test.go)
Reviewed changes
Copilot reviewed 20 out of 27 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| system-tests/tests/go.mod | Updated chainlink-evm dependency version |
| system-tests/lib/go.mod | Updated chainlink-evm dependency version |
| integration-tests/smoke/ccip/ccip_reader_test.go | Added read package import and updated function calls |
| integration-tests/smoke/ccip/ccip_reader_bench_test.go | Added read package import and updated function call |
| integration-tests/load/go.mod | Updated chainlink-evm dependency version |
| integration-tests/go.mod | Updated chainlink-evm dependency version |
| go.mod | Updated chainlink-evm dependency version |
| deployment/go.mod | Updated chainlink-evm dependency version |
| core/services/relay/evm/plugin_provider.go | Updated type reference to use read.ChainReaderService |
| core/services/relay/evm/evmtesting/chain_components_interface_tester.go | Added read package import and updated function call |
| core/services/relay/evm/evm.go | Updated type references and function calls to use read package |
| core/services/relay/evm/chain_reader_test.go | Deleted test file |
| core/services/relay/evm/chain_reader.go | Deleted implementation file |
| core/services/relay/evm/chain_components_test.go | Added read package import and updated function calls |
| core/services/relay/evm/capabilities/testutils/backend.go | Added read package import and updated function call |
| core/services/registrysyncer/v2/syncer_test.go | Added read package import and updated function call |
| core/services/registrysyncer/syncer_test.go | Added read package import and updated function call |
| core/scripts/go.mod | Updated chainlink-evm dependency version |
| core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go | Added read package import and updated function call |
| core/capabilities/ccip/ccip_integration_tests/integrationhelpers/integration_helpers.go | Added read package import and updated function calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Minor. * Minor. * Minor.
|


Requires smartcontractkit/chainlink-evm#342