Skip to content

Conversation

@pavel-raykov
Copy link
Collaborator

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@trunk-io
Copy link

trunk-io bot commented Jan 27, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@pavel-raykov pavel-raykov marked this pull request as ready for review January 27, 2026 14:45
@pavel-raykov pavel-raykov requested review from a team as code owners January 27, 2026 14:45
Copilot AI review requested due to automatic review settings January 27, 2026 14:45
@pavel-raykov pavel-raykov requested review from a team as code owners January 27, 2026 14:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codebase to use the read.NewChainReaderService function from the chainlink-evm package instead of the previously used evm.NewChainReaderService from the local codebase. The change reflects that the EVM service has been moved to the external chainlink-evm repository.

Changes:

  • Updated chainlink-evm dependency version across all module files
  • Migrated from local evm.NewChainReaderService to chainlink-evm/pkg/read.NewChainReaderService
  • Removed local chain reader implementation files (chain_reader.go and chain_reader_test.go)

Reviewed changes

Copilot reviewed 20 out of 27 changed files in this pull request and generated no comments.

Show a summary per file
File Description
system-tests/tests/go.mod Updated chainlink-evm dependency version
system-tests/lib/go.mod Updated chainlink-evm dependency version
integration-tests/smoke/ccip/ccip_reader_test.go Added read package import and updated function calls
integration-tests/smoke/ccip/ccip_reader_bench_test.go Added read package import and updated function call
integration-tests/load/go.mod Updated chainlink-evm dependency version
integration-tests/go.mod Updated chainlink-evm dependency version
go.mod Updated chainlink-evm dependency version
deployment/go.mod Updated chainlink-evm dependency version
core/services/relay/evm/plugin_provider.go Updated type reference to use read.ChainReaderService
core/services/relay/evm/evmtesting/chain_components_interface_tester.go Added read package import and updated function call
core/services/relay/evm/evm.go Updated type references and function calls to use read package
core/services/relay/evm/chain_reader_test.go Deleted test file
core/services/relay/evm/chain_reader.go Deleted implementation file
core/services/relay/evm/chain_components_test.go Added read package import and updated function calls
core/services/relay/evm/capabilities/testutils/backend.go Added read package import and updated function call
core/services/registrysyncer/v2/syncer_test.go Added read package import and updated function call
core/services/registrysyncer/syncer_test.go Added read package import and updated function call
core/scripts/go.mod Updated chainlink-evm dependency version
core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go Added read package import and updated function call
core/capabilities/ccip/ccip_integration_tests/integrationhelpers/integration_helpers.go Added read package import and updated function calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pavel-raykov pavel-raykov added this pull request to the merge queue Jan 27, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 27, 2026
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
14.8% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2026
@pavel-raykov pavel-raykov added this pull request to the merge queue Jan 27, 2026
Merged via the queue into develop with commit 2c7dd26 Jan 27, 2026
243 of 246 checks passed
@pavel-raykov pavel-raykov deleted the move-read2 branch January 27, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants