-
Notifications
You must be signed in to change notification settings - Fork 64
chore: Upgrade brod dependency to v4 #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't mind to brod updating. For example, on MacOS it could be done by running |
|
Thanks for the response. Removing the system-dependent dependency would be a big improvement. We build multi-arch Docker images and use the same source on both macOS and Linux containers, so the architecture mismatch prevents us from sharing the same compilation binaries. It's not a problem with Kaffe library per-se but as the new version of Brod just remove this sub dependency it's a good way of removing the side effect of having snappyer. |
9bbb1a2 to
78c0bab
Compare
|
Hello, any update on this? We would like to use brod 4.X because it has some important connection improvements |
78c0bab to
c8a72be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the brod dependency from v3 to v4 to resolve compilation issues with Erlang 27 and Elixir 1.17.2. The upgrade removes the problematic snappyer sub-dependency that was causing build failures.
Key Changes:
- Bumped brod dependency from ~> 3.0 to ~> 4.0
- Added crc32cer dependency constraint
- Documented breaking changes for compression support configuration
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| mix.exs | Updated brod to v4.0, added crc32cer dependency, and bumped project version to 2.0.0 |
| README.md | Added new "Compression Config" section documenting required configuration for snappy/lz4 compression |
| CHANGELOG.md | Added v2.0.0 release notes with breaking changes and upgrade instructions for compression support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also removes unused deps from mix.lock
c8a72be to
97bfb54
Compare
fatcatt316
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May have caught one link that could be changed, but besides that, I think this looks good to include in v2 (along with #160) 👍
Trying to compile kaffe throws the following error
using erlang 27 and elixir 1.17.2
The problem is related a sub dependency of Brod library. This sub dependency was removed in Brod 4.0