Convert consumer config to keyword #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map based config doesn't automatically merge config values, which means that each environment, if changing a consumer, must define the _entire_ consumer's config.
TylerWitt
requested review from
Copilot and
fatcatt316
and removed request for
Copilot
Contributor
Author
|
Closes #157 |
fatcatt316
approved these changes
Jan 9, 2026
|
Hello, Thank you for kaffe! |
Contributor
Author
Merged! |
Thank you. Are you planning to bundle this with some more PRs, f.i. #144, before the next release (major bump), @TylerWitt? I added Kaffe as dependency a few minutes ago and learned about the requirement of a c++ executable to build snappyer - which I am not planning to use. IIUC, Brod 4.x does not depend on snappyer, i.e. that problem would disappear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map based config doesn't automatically merge config values, which means that each environment, if changing a consumer, must define the entire consumer's config.