-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_protobuf: add version_constant_commitment to ConsensusBlockInfo #11751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: asmaa/add_parent_proposal_commitment_to_blockinfo
Are you sure you want to change the base?
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).
crates/apollo_protobuf/src/consensus.rs line 122 at r1 (raw file):
pub parent_proposal_commitment: Option<ProposalCommitment>, /// Version constant commitment. pub version_constant_commitment: BlockHash,
Are you sure this is the correct type?
Code quote:
BlockHash
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware reviewed 8 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).
a5689d0 to
6b48d66
Compare
b8d05d2 to
2b61cf5
Compare

No description provided.