Skip to content

Conversation

@asmaastarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

asmaastarkware commented Jan 15, 2026

@asmaastarkware asmaastarkware marked this pull request as ready for review January 15, 2026 14:14
Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).


crates/apollo_protobuf/src/consensus.rs line 122 at r1 (raw file):

    pub parent_proposal_commitment: Option<ProposalCommitment>,
    /// Version constant commitment.
    pub version_constant_commitment: BlockHash,

Are you sure this is the correct type?

Code quote:

BlockHash

Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 8 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).

@asmaastarkware asmaastarkware force-pushed the asmaa/add_version_constant_commitment_to_info branch from a5689d0 to 6b48d66 Compare January 18, 2026 07:54
@asmaastarkware asmaastarkware force-pushed the asmaa/add_parent_proposal_commitment_to_blockinfo branch from b8d05d2 to 2b61cf5 Compare January 18, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants