-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_protobuf: add concatenated_counts to fin #11752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: asmaa/add_version_constant_commitment_to_info
Are you sure you want to change the base?
apollo_protobuf: add concatenated_counts to fin #11752
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware made 1 comment.
Reviewable status: 0 of 18 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).
crates/apollo_protobuf/src/proto/p2p/proto/consensus/consensus.proto line 73 at r1 (raw file):
uint64 executed_transaction_count = 2; // Concatenated counts. Felt252 concatenated_counts = 3;
We agreed to add this field (and its followers) as an optional message in the Fin.
Meaning that all the stuff required to calculate the proposal commitment may or may not be sent, basically telling "we might not send this at all, and you should not rely on it".
Code quote (i):
Felt252 concatenated_counts = 3;Code snippet (ii):
message ProposalCommitmentComponents {
Felt252 concatenated_counts = 1;
All the other fields of the message...
}
message ProposalFin {
...
optional ProposalCommitmentComponents commitment_components = 3;
}
No description provided.