Skip to content

Conversation

@asmaastarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

asmaastarkware commented Jan 15, 2026

@github-actions
Copy link

Artifacts upload workflows:

Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware made 1 comment.
Reviewable status: 0 of 18 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @dafnamatsry).


crates/apollo_protobuf/src/proto/p2p/proto/consensus/consensus.proto line 73 at r1 (raw file):

    uint64 executed_transaction_count = 2;
    // Concatenated counts.
    Felt252 concatenated_counts = 3;

We agreed to add this field (and its followers) as an optional message in the Fin.
Meaning that all the stuff required to calculate the proposal commitment may or may not be sent, basically telling "we might not send this at all, and you should not rely on it".

Code quote (i):

Felt252 concatenated_counts = 3;

Code snippet (ii):

message ProposalCommitmentComponents {
    Felt252 concatenated_counts = 1;
    All the other fields of the message...
}

message ProposalFin {
    ...
       
    optional ProposalCommitmentComponents commitment_components = 3;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants