Fixed security exception being thrown when cookies are disabled#6
Open
alexgorbatchev wants to merge 2 commits intotwilio:masterfrom
Open
Fixed security exception being thrown when cookies are disabled#6alexgorbatchev wants to merge 2 commits intotwilio:masterfrom
alexgorbatchev wants to merge 2 commits intotwilio:masterfrom
Conversation
Contributor
|
Is there a way to write a unit test for this case? I'm not sure there is, but it would be nice if there's a way. |
Author
|
Added a unit test for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module blows up when cookies are disabled in the browser settings. This addresses the issue by simply returning out of the module leaving it up to the user to determine how to handle that.