Skip to content

Fixed security exception being thrown when cookies are disabled #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexgorbatchev wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed security exception being thrown when cookies are disabled #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da2d1c5
Fixed security exception being thrown when cookies are disabled
alexgorbatchev Sep 3, 2013
5c8fab3
Added test for the disabled cookies test
alexgorbatchev Sep 3, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,16 @@ min: bankersbox.min.js

test:
@echo "Testing bankersbox.js:"
@NODE_PATH=`pwd` expresso -s tests/*
@NODE_PATH=`pwd` ./node_modules/.bin/expresso -s tests/*.test.coffee
@NODE_PATH=`pwd` ./node_modules/.bin/expresso -s tests/*.test_special.coffee

testmin: min
@mkdir -p src-min-tmp
@rm -f src-min-tmp/bankersbox.js
@ln -s ../bankersbox.min.js src-min-tmp/bankersbox.js
@echo "Testing MINIFIED file:"
@NODE_PATH=`pwd`/src-min-tmp expresso -s tests/*
@NODE_PATH=`pwd`/src-min-tmp ./node_modules/.bin/expresso -s tests/*
@NODE_PATH=`pwd`/src-min-tmp ./node_modules/.bin/expresso -s tests/*.test_special.coffee

testall: test testmin

Expand All @@ -32,7 +34,7 @@ coverage:
rm -f src-tmp/bankersbox.js
ln -s ../bankersbox.js src-tmp/bankersbox.js
rm -rf src-cov
node-jscoverage src-tmp src-cov
NODE_PATH=`pwd`/src-cov expresso -s tests/*
./node_modules/.bin/node-jscoverage src-tmp src-cov
NODE_PATH=`pwd`/src-cov ./node_modules/.bin/expresso -s tests/*.test.coffee

.PHONY: all clean min test testmin testall coverage
8 changes: 8 additions & 0 deletions bankersbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@
window = {};
}

try {
// when cookies are disabled accessing `window.localStorage` throws ERR 18
window.localStorage;
}
catch (e) {
return;
}

if (typeof(window.localStorage) === 'undefined' && ctx !== window) {
// fake out localStorage functionality, mostly for testing purposes
window.localStorage = {};
Expand Down
8 changes: 8 additions & 0 deletions tests/bb_cookies_disabled.test_special.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
GLOBAL.window = {}
Object.defineProperty window, 'localStorage', get: -> throw 'ERR'

assert = require "assert"
{ BankersBox } = require "bankersbox"

exports.testWithCookiesDisabled = ->
assert.equal BankersBox, undefined, "BankersBox is expected to be undefined"