Add decryption/encryption dedicated APIs #288
Merged
+58
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidou
reviewed
Nov 20, 2025
youennf
commented
Nov 20, 2025
guidou
reviewed
Nov 20, 2025
youennf
commented
Nov 20, 2025
youennf
commented
Nov 20, 2025
jan-ivar
reviewed
Nov 20, 2025
guidou
approved these changes
Nov 20, 2025
jan-ivar
reviewed
Nov 20, 2025
jan-ivar
reviewed
Nov 20, 2025
Removing fixme in favour of w3c#289
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
youennf
force-pushed
the
add-key-management-api
branch
from
5bca503 to
f842e48
Compare
jan-ivar
reviewed
Dec 18, 2025
youennf
commented
Dec 18, 2025
jan-ivar
reviewed
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
jan-ivar
approved these changes
Dec 18, 2025
index.bs
Outdated
| 1. [=Queue a task=] to [=resolve=] |promise| with undefined. | ||
| 1. Return |promise|. | ||
|
|
||
| The <dfn method for="SFrameDecrypterKeyManager">addDecryptionKey(|key|, |keyID|)</dfn> method steps are: |
youennf
commented
Dec 18, 2025
Collaborator
Author
|
I'll update the PR to make the setEncryptionKey keyID parameter mandatory. This simplifies things and should be good enough. |
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
youennf
commented
Dec 18, 2025
| }; | ||
|
|
||
| [Exposed=Window] | ||
| interface SFrameSenderTransform { |
There was a problem hiding this comment.
There was a question in the past if SFrameTransform should have a 'RTC' prefix as other webrtc related stuff. I believe the answer not to add here a prefix had a good explanation that sframe is something bigger than just webrtc. Is this still relevant in current situation when sframe transform got splitted to sender/receiver? For me it in some way points now that webrtc will be main user of this transform.
Collaborator
Author
There was a problem hiding this comment.
It makes sense to rename to RTCSFrameTransfrom, since it can only be used in RTC context now.
Let's do this in a follow-up though.
github-actions bot
added a commit
that referenced
this pull request
Dec 19, 2025
SHA: ff25691 Reason: push, by youennf Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Preview | Diff