-
Notifications
You must be signed in to change notification settings - Fork 27
Add decryption/encryption dedicated APIs #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
0565a30
Add decryption/encryption dedicated APIs
youennf 4867772
Introduce sender and receiver transforms
youennf 25562b2
Apply suggestions from code review
youennf 226007d
Update index.bs
youennf 68c323b
Update index.bs
youennf d733f5f
Update index.bs
youennf 8594e5d
Update index.bs
youennf b5097af
Reuse infra map set
youennf f842e48
Fix bikeshed link
youennf 58262ce
Fix video frame type
youennf c94cbd3
Update index.bs
youennf eeefa7a
Update index.bs
youennf de082cd
Update index.bs
youennf 45d2d9b
Update index.bs
youennf 647e642
Update index.bs
youennf f8b612b
Update index.bs
youennf caae168
Update index.bs
youennf 58f13e1
Update index.bs
youennf f8361b5
Update index.bs
youennf a036914
Update index.bs
youennf fcaf724
Update index.bs
youennf 3f5bff2
Update index.bs
youennf 6497737
Update index.bs
youennf 25e3635
Update index.bs
youennf 32bc221
Update index.bs
youennf f0e9a73
Update index.bs
youennf 1badf3c
Update index.bs
youennf 7e5676f
Update index.bs
youennf 5448ecb
Update index.bs
youennf d867b65
Update index.bs
youennf 9a634e4
Fix links
youennf e72f350
Remove keyId undefined handling
youennf 5905a63
Use infra remove like done for set
youennf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a question in the past if SFrameTransform should have a 'RTC' prefix as other webrtc related stuff. I believe the answer not to add here a prefix had a good explanation that sframe is something bigger than just webrtc. Is this still relevant in current situation when sframe transform got splitted to sender/receiver? For me it in some way points now that webrtc will be main user of this transform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to rename to RTCSFrameTransfrom, since it can only be used in RTC context now.
Let's do this in a follow-up though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uploaded #291