port iota integration into xaynet os repo

[Robert-Steiner]

No description provided.

[codecov]

Codecov Report

Merging #636 (e54b430) into master (dbaa0e5) will decrease coverage by 0.51%.
The diff coverage is 37.65%.

@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   61.51%   61.00%   -0.52%     
==========================================
  Files         102      102              
  Lines        4563     4559       -4     
==========================================
- Hits         2807     2781      -26     
- Misses       1756     1778      +22     

Impacted Files	Coverage Δ
rust/xaynet-server/src/settings/mod.rs	90.62% <0.00%> (-1.57%)	⬇️
rust/xaynet-server/src/settings/s3.rs	91.30% <ø> (ø)
rust/xaynet-server/src/state_machine/mod.rs	75.00% <ø> (ø)
...ver/src/storage/coordinator_storage/redis/impls.rs	72.72% <0.00%> (ø)
...erver/src/storage/coordinator_storage/redis/mod.rs	71.20% <ø> (ø)
rust/xaynet-server/src/storage/traits.rs	66.66% <ø> (ø)
...ynet-server/src/storage/trust_anchor/iota/utils.rs	0.00% <0.00%> (ø)
...net-server/src/storage/trust_anchor/iota/client.rs	2.98% <2.98%> (ø)
rust/xaynet-server/src/storage/store.rs	80.00% <72.72%> (ø)
...t/xaynet-server/src/state_machine/phases/unmask.rs	58.33% <75.00%> (ø)
... and 50 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbaa0e5...8feec80. Read the comment docs.

[Robert-Steiner]

/deploy COORDINATOR_FEATURES=metrics,iota

[Robert-Steiner]

/deploy COORDINATOR_FEATURES=metrics,iota

[wilk10]

Thanks a lot! LGTM, but perhaps seek the approval of someone else too?

[little-dude]

Very neat :) Funny how such an innocent looking trait leads to such improvement through the entire state machine. Why is the is_ready needed though? CoordinatorStorage, ModelStorage and TrustAnchor all have an is_ready method already.

[Robert-Steiner]

@little-dude 🎉

Very neat :) Funny how such an innocent looking trait leads to such improvement through the entire state machine.

Yeah I agree😊. It is awesome to see that it work this way without dynamic dispatch.

The is_ready method combines the is_ready methods of CoordinatorStorage, ModelStorage and TrustAnchor and is called in the state machine error phase.

[wilk10]

@little-dude !! are you dynamically dispatching meals to people doorsteps already?

[finiteprods]

looks great. I don't have much domain knowledge around the iota parts, so can't say much there. perhaps more docstrings there (particularly for pub functions) would be helpful, but you don't need to do it straight away. Also I wasn't able to see your lovely module documentation when i did cargo doc, maybe just a problem with my setup, or was this intentional? I agree with @little-dude 's comment that the changes to the state machine make it simpler and more extensible, which is great.

[finiteprods]

personally for consistency i would say <S, T> and add a comment on what they represent, but I'm ok with this too if you prefer it.

[finiteprods]

A-Z and just 9? that's quirky...