🏛️Product base types: Support in the integrator#1315
Merged
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a new productBaseType field into the publishing workflow, ensuring it is passed through both the product API and template selection logic.
- Extract and forward
productBaseTypeinprepare_product - Extend
get_publish_template_nameto accept and filter byproduct_base_type
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/ayon_core/plugins/publish/integrate.py | Added extraction of productBaseType and passed it to update calls |
| client/ayon_core/pipeline/publish/lib.py | Extended get_publish_template_name signature and filter criteria |
Comments suppressed due to low confidence (3)
client/ayon_core/plugins/publish/integrate.py:380
- The
create_productcall does not include the newproduct_base_typeparameter, so newly created products won't have this field set. Addproduct_base_type=product_base_typeto thecreate_productinvocation to maintain consistency with the update path.
attribs=attributes
client/ayon_core/pipeline/publish/lib.py:141
- Filtering by
product_base_typewas added to the criteria, but there are no existing tests that cover templates selected based on this new filter. Consider adding unit tests forget_publish_template_namescenarios with differentproduct_base_typevalues.
"product_base_types": product_base_type,
client/ayon_core/pipeline/publish/lib.py:130
- The docstring for
product_base_typestill refers to it as a generic "Product type". Update this to clearly describe it as the "Product base type" to avoid confusion withproduct_type.
product_base_type (Optional[str]): Product type for which should
iLLiCiTiT
reviewed
Nov 28, 2025
iLLiCiTiT
reviewed
Nov 28, 2025
…roduct-base-types-support-in-integrator
iLLiCiTiT
reviewed
Dec 2, 2025
iLLiCiTiT
reviewed
Dec 2, 2025
iLLiCiTiT
reviewed
Dec 2, 2025
when product base types are not supported by api, product base type should be the source of truth.
…pes-support-in-integrator' into enhancement/1296-product-base-types-support-in-integrator
iLLiCiTiT
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Integrate
product base typeinto AYON on publishing.Additional info
If instance has
product base typedefined, integrate it.Closes #1296
Note
This requires ynput/ayon-python-api#255 and definitely ynput/ayon-backend#575
For more information about product base types and testing see description here #1297