Accept existing SuperToken in RewardsManager ctor #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
Collaborator
Author
This was referenced Sep 10, 2025
Why: Remove wrapper creation from constructor; require SENDx to be provided to simplify lifecycle. Test plan: - Compile and run rewards manager tests. - Confirm no wrapper creation occurs in ctor.
Why: Decouple wrapper creation from rewards by requiring an existing ISuperToken (SENDx) to be passed into the RewardsManager constructor. This simplifies lifecycle, avoids implicit wrapper creation, and clarifies responsibilities between features. Details: - RewardsManager ctor now accepts SENDx; no wrapper creation - Deploy and tests updated to pass SENDx explicitly - Docs updated to reflect new constructor and flows - Maintains minimal admin surface and pool creation via SuperTokenV1Library Test plan: - bunx hardhat compile (succeeds) - bunx hardhat test test/rewards.manager.test.ts - bunx hardhat run scripts/rewards/deploy.ts --network anvil (SENDx resolved; pool is created; deployments updated)
youngkidwarrior
changed the base branch from
script_rewards_deploy_resolve_sendx_share_require_pool_addr_
to
graphite-base/15
youngkidwarrior
force-pushed
the
feat_rewards_accept_existing_supertoken_in_rewardsmanager_constructor_remove_wrapper_creation
branch
from
472d60d to
f613b72
Compare
youngkidwarrior
changed the base branch from
graphite-base/15
to
feat_rewards_manager_pool_units_sync_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Remove wrapper creation from constructor; require SENDx to be
provided to simplify lifecycle.
Test plan: