-
Notifications
You must be signed in to change notification settings - Fork 0
Add UNDERLYING_ADDRESS override for wrapper #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
youngkidwarrior
wants to merge
1
commit into
chore_wire_anvil_deploy_to_wrapper_create_script_and_set_anvil_signer_via_eoa_deployer
Choose a base branch
from
feat_wrapper_add_underlying_address_override_keep_canonical_create_validation_flow
base: chore_wire_anvil_deploy_to_wrapper_create_script_and_set_anvil_signer_via_eoa_deployer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
Collaborator
Author
This was referenced Sep 10, 2025
7509f03 to
e418790
Compare
f44d3af to
d7ea47b
Compare
…ndearnrewards_bubble_erc4626_hooks_factory-gated_join_flow (886f744) Why: Apply the same non-artifacts changes from top-of-stack to this branch: - Rename RewardsAggregator -> SendEarnRewards - Bubble ERC4626 hooks; factory-gated vault routing - Ignition module rename; minimal tests/mocks; docs labels Test plan: - npx hardhat compile - npx hardhat test --grep "SendEarnRewards"
d7ea47b to
64cece5
Compare
e418790 to
3d61001
Compare
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Why:
Allow overriding the underlying token address while keeping
canonical/create validation flow.
Test plan: