Completed P Controller for Pose to Pose Control #6
Open
Andy-Li308 wants to merge 5 commits intoCL2-UWaterloo:mainfrom
Open
Completed P Controller for Pose to Pose Control #6Andy-Li308 wants to merge 5 commits intoCL2-UWaterloo:mainfrom
Andy-Li308 wants to merge 5 commits intoCL2-UWaterloo:mainfrom
Conversation
…removed excessive file writes
Author
|
Hi Praneeth, I've made the changes that you mentioned, the controller node now has ROS2 parameters for all the respective controller parameters that can be set and changed in the launch file without having to recompile the C++ source code. In addition, the angle wrapping logic has been improved so that it is now O(1) time complexity, and the robots logging data is now stored in a vector which is then copied into the .csv file in the destructor. This avoid writing to the file on every single iteration of the loop. Let me know what you think and if you have any other comments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drives the robot from its start position to x= 5, y = 5, with an angle of 90 degrees using P control implimented in ROS. Output graphs showing robot path and x, y errors over time can be found under the plots/ folder.