Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

@GraDKh
Copy link
Contributor

@GraDKh GraDKh commented Jun 16, 2025

Move test utilities from compute to core

TL;DR

Created a new binius_core_test_utils crate and moved test utilities related to core functionality from binius_compute_test_utils.

What changed?

  • Created a new crates/core/test_utils directory with its own Cargo.toml
  • Moved the following modules from compute/test_utils to core/test_utils:
    • bivariate_sumcheck
    • piop
    • ring_switch
  • Updated imports in affected test files to use the new crate
  • Added binius_core_test_utils as a dev-dependency in crates/core/Cargo.toml

How to test?

Run the tests in the core crate to ensure they still pass with the new test utilities:

cargo test -p binius_core

Why make this change?

This change improves the organization of test utilities by placing them closer to the code they're testing. Test utilities specific to core functionality now live in the core crate, making the codebase more modular and easier to maintain.

Copy link
Contributor Author

GraDKh commented Jun 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@GraDKh GraDKh force-pushed the dgordon/move_compute_test_utils branch from 85ef870 to 2a5f336 Compare June 20, 2025 12:34
@GraDKh GraDKh force-pushed the dgordon/add_core_test_utils_crate branch from 06dd05b to cc9e819 Compare June 20, 2025 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants