Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

@GraDKh
Copy link
Contributor

@GraDKh GraDKh commented Jun 16, 2025

TL;DR

Moved bivariate sumcheck tests from individual modules to a centralized location using a macro.

What changed?

  • Removed test modules from bivariate_mlecheck.rs and bivariate_product.rs
  • Added a new macro instantiate_bivariate_sumcheck_tests! in bivariate_sumcheck.rs that generates the test functions
  • Created a new test file bivariate_sumcheck.rs that uses the macro to instantiate tests for both CPU and Fast CPU layers

How to test?

Run the tests to ensure they still pass:

cargo test --package binius-core --test bivariate_sumcheck

Why make this change?

This refactoring improves code organization by:

  1. Centralizing test logic in a single location
  2. Reducing code duplication through the use of a macro
  3. Making it easier to maintain and extend tests for different compute layer implementations

Copy link
Contributor Author

GraDKh commented Jun 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@GraDKh GraDKh force-pushed the dgordon/add_macros_for_compute_tests branch from e713605 to f99161f Compare June 16, 2025 19:51
@GraDKh GraDKh force-pushed the dgordon/extract_bivariate_sumcheck_macro branch 2 times, most recently from 6fdf946 to d40060a Compare June 16, 2025 19:59
@GraDKh GraDKh marked this pull request as ready for review June 16, 2025 20:12
Copy link
Contributor

@djadjka djadjka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GraDKh GraDKh force-pushed the dgordon/add_macros_for_compute_tests branch from f99161f to ed8424c Compare June 20, 2025 12:34
@GraDKh GraDKh force-pushed the dgordon/extract_bivariate_sumcheck_macro branch from d40060a to 2d9c88d Compare June 20, 2025 12:34
@GraDKh GraDKh force-pushed the dgordon/extract_bivariate_sumcheck_macro branch from 2d9c88d to f2aa965 Compare June 20, 2025 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants