Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

Conversation

@GraDKh
Copy link
Contributor

@GraDKh GraDKh commented Jun 16, 2025

TL;DR

Introduce a macro to instantiate all compute layer tests with the given compute layer type.

What changed?

  • Fixed memory alignment issues in test_generic_multiple_multilinear_evaluations and test_generic_map_with_multilinear_evaluations functions by properly handling device memory alignment requirements
  • Added a new instantiate_compute_layer_tests! macro that generates all the standard compute layer tests for a given tower, HAL, and compute holder type
  • Refactored the test files in crates/compute/tests/layer.rs and crates/fast_compute/tests/layer.rs to use the new macro, significantly reducing code duplication

How to test?

Run the compute layer tests to verify they pass with the new alignment handling:

cargo test -p binius-compute
cargo test -p binius-fast-compute

Why make this change?

The new macro eliminates significant code duplication across test files, making it easier to maintain and extend the test suite in the future.

Copy link
Contributor Author

GraDKh commented Jun 16, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@GraDKh GraDKh force-pushed the dgordon/add_core_test_utils_crate branch from 06dd05b to cc9e819 Compare June 20, 2025 12:34
@GraDKh GraDKh force-pushed the dgordon/add_macros_for_compute_tests branch from f99161f to ed8424c Compare June 20, 2025 12:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants