Skip to content

Conversation

@daveey
Copy link
Contributor

@daveey daveey commented Dec 3, 2025

No description provided.

@daveey daveey marked this pull request as ready for review December 3, 2025 00:12
Copy link
Contributor Author

daveey commented Dec 3, 2025

@datadog-official

This comment has been minimized.

Comment on lines 194 to 196
num_layers=trunk_num_resnet_layers,
pattern="A", # Axon blocks provide residual-like connections
post_norm=trunk_use_layer_norm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NameError: Undefined variable reference

The code references trunk_num_resnet_layers and trunk_use_layer_norm in the components list default value, but these variables are not in scope at class definition time. Class attributes defined above (lines 165, 167) cannot be referenced by name in other class attribute default values.

This will cause an immediate NameError when the class is defined:

NameError: name 'trunk_num_resnet_layers' is not defined

Fix: Either use hardcoded values in the default or use _latent_dim pattern with underscore prefix, or move this logic to __post_init__ or the make_policy method where instance attributes are accessible.

Suggested change
num_layers=trunk_num_resnet_layers,
pattern="A", # Axon blocks provide residual-like connections
post_norm=trunk_use_layer_norm,
num_layers=4, # Default value
pattern="A", # Axon blocks provide residual-like connections
post_norm=True, # Default value

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@openhands-ai
Copy link

openhands-ai bot commented Dec 3, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • Test and Benchmark

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #4148 at branch `daveey-vitres`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

@daveey daveey changed the base branch from daveey-vp to graphite-base/4148 December 9, 2025 07:53
@daveey daveey closed this Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants