fix: SimulationAgent.inventory reads only from agent's own position #4239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 8, 2025
Draft
Closed
The inventory property was iterating through ALL observation tokens (including other agents' inventories) instead of only looking at tokens at the center position where the agent sees itself.
daveey
force-pushed
the
daveey-fix-sim-inv
branch
from
a0936ef to
a7af05b
Compare
relh
approved these changes
Dec 8, 2025
Contributor
relh
left a comment
relh
left a comment
There was a problem hiding this comment.
we might want to make sure the simulator re-write isn't doing more things like this
zfogg
pushed a commit
that referenced
this pull request
Dec 20, 2025
…4239) The inventory property was iterating through ALL observation tokens (including other agents' inventories) instead of only looking at tokens at the center position where the agent sees itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inventory property was iterating through ALL observation tokens
(including other agents' inventories) instead of only looking at
tokens at the center position where the agent sees itself.