skydeck #4237
skydeck #4237
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
daveey
force-pushed
the
daveey-skytower
branch
from
17eb097 to
fe4a426
Compare
daveey
force-pushed
the
daveey-cvc-diversity
branch
from
aec5381 to
4eab0c8
Compare
daveey
force-pushed
the
daveey-cvc-diversity
branch
from
4eab0c8 to
c965d51
Compare
daveey
force-pushed
the
daveey-skytower
branch
2 times, most recently
from
acc2427 to
842df15
Compare
daveey
force-pushed
the
daveey-cvc-diversity
branch
2 times, most recently
from
805624d to
4863989
Compare
daveey
force-pushed
the
daveey-skytower
branch
3 times, most recently
from
2d56b2c to
cfbb106
Compare
Skydeck is a web dashboard for tracking and managing ML experiments with: - SQLite-backed experiment state management - W&B integration for experiment syncing - Flag-based experiment configuration - Web UI for monitoring experiment status
daveey
force-pushed
the
daveey-cvc-diversity
branch
from
4863989 to
b52bd87
Compare
daveey
force-pushed
the
daveey-skytower
branch
from
cfbb106 to
1438c6c
Compare
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Always add run name using experiment ID | ||
| parts.append(f"run={self.id}") |
There was a problem hiding this comment.
The command builder always appends run={self.id} and there is no hook for the run_name field even though the schema and tables include a run_name column and tests construct experiments with a separate run name. Whenever a caller supplies a custom run_name (e.g., to match existing W&B runs), it is silently ignored and the command always uses the experiment id instead, so generated runs cannot be aligned with the requested name.
Useful? React with 👍 / 👎.
| async def update_experiment_state(self, experiment_id: str, current_state: JobStatus): | ||
| """Update experiment current state.""" | ||
| await self._conn.execute( | ||
| """ | ||
| UPDATE experiments | ||
| SET current_state = ?, updated_at = ? | ||
| WHERE id = ? | ||
| """, | ||
| (current_state.value, datetime.utcnow().isoformat(), experiment_id), |
There was a problem hiding this comment.
The update_experiment_state method only takes a status and updates current_state, ignoring the current_job_id column that exists in the schema and is passed by callers/tests. Invocations that provide a job id raise a TypeError, and even two-arg calls never record which job produced the state, so the database cannot track the active job for an experiment.
Useful? React with 👍 / 👎.
cp
feat: add skydeck experiment dashboard
Skydeck is a web dashboard for tracking and managing ML experiments with:
Update pyproject.toml and uv.lock
Commit skydeck files