Replace number_of_vibes with explicit vibes list in change_vibe action config #4489

daveey · 2025-12-22T18:23:42Z

TL;DR

Refactored vibe configuration to use explicit vibe lists instead of numeric counts.

What changed?

Changed change_vibe.number_of_vibes to change_vibe.vibes across the codebase
Updated all references to use the new explicit vibe list configuration
Modified documentation to reflect the new configuration approach
Updated test cases to use the new vibe configuration pattern
Ensured backward compatibility with existing code by maintaining the same behavior

How to test?

Run existing tests to verify they pass with the new configuration

Create a configuration with specific vibes and verify they're properly applied:

from mettagrid.config.vibes import VIBE_BY_NAME
cfg.game.actions.change_vibe.vibes = [VIBE_BY_NAME["happy"], VIBE_BY_NAME["sad"]]

Verify that the vibe names in the game configuration match the vibes specified
Test that the action space correctly reflects only the specified vibes

Why make this change?

The previous approach of using a numeric count (number_of_vibes) to limit available vibes was inflexible, as it only allowed using the first N vibes from the predefined list. This change enables explicit selection of which vibes should be available, allowing for more customized configurations without being constrained to the order of vibes in the default list. This is particularly useful for specialized environments that need specific vibes without including all preceding ones.

daveey · 2025-12-22T18:24:16Z

Enhance attack system with armor, weapons, and configurable loot #4313 : 2 dependent PRs (#4321 , #4477 )
Make Transfer action optional and add vibe-triggered attack #4315
Implement bidirectional resource transfer system with vibe-based triggers #4314
Replace number_of_vibes with explicit vibes list in change_vibe action config #4489 👈 (View in Graphite)
Refactor inventory system into dedicated InventoryConfig class #4356 : 2 other dependent PRs (#4328 , #4355 )
Add ignore_limits parameter to inventory updates for initial setup #4360
Rename test_performance to run_performance in mettagrid to avoid running in pytest #4370
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-12-22T18:30:59Z

packages/mettagrid/python/src/mettagrid/config/mettagrid_c_config.py

            config_dict["obs"] = config_dict["obs"].copy()
            config_dict["obs"].pop("features", None)
-        # Keep vibe_names in sync with number_of_vibes; favor the explicit count.
+        # Keep vibe_names in sync with vibes; favor the vibes list.
        config_dict.pop("vibe_names", None)
-        change_vibe_cfg = config_dict.setdefault("actions", {}).setdefault("change_vibe", {})
-        change_vibe_cfg["number_of_vibes"] = change_vibe_cfg.get("number_of_vibes") or len(VIBES)
        game_config = GameConfig(**config_dict)


Legacy configs with number_of_vibes now fail validation

convert_to_cpp_game_config now instantiates GameConfig directly from the supplied dict without translating the old actions.change_vibe.number_of_vibes field into the new vibes list. GameConfig inherits extra="forbid", so any previously serialized configs or checkpoints that still include number_of_vibes will raise a validation error when Simulation passes them through this path, breaking the backward compatibility the refactor was meant to preserve. Consider mapping the legacy key to vibes (or dropping it) before calling GameConfig(**config_dict) to keep older configs working.

Useful? React with 👍 / 👎.

this seems fine? I dont know if we need older configs, maybe just older policies (maybe)

relh

Socratic reviewing is great and I like this change also.

observations/actions/vibes could become a singular "language" that we have an interface to both encoding for the policy with a tokenizer and decoding from the policy

relh · 2025-12-23T16:31:43Z

packages/cogames/scripts/run_evaluation.py

-            change_vibe.number_of_vibes = 8
+        has_gear = any(v.name == "gear" for v in change_vibe.vibes)
+        if not has_gear:
+            from mettagrid.config.vibes import VIBE_BY_NAME


this is kind of ugly can this import be at the top?

relh · 2025-12-23T16:31:51Z

packages/cogames/src/cogames/policy/nim_agents/thinky_eval.py

-                change_vibe.number_of_vibes = 8
+            has_gear = any(v.name == "gear" for v in change_vibe.vibes)
+            if not has_gear:
+                from mettagrid.config.vibes import VIBE_BY_NAME


this is kind of ugly can this import be at the top?

relh · 2025-12-23T16:32:20Z

packages/cogames/TECHNICAL_MANUAL.md

 - `change_vibe_neutral`

-> **Note**: The number of available vibes is configurable via `change_vibe.number_of_vibes`.
+> **Note**: The available vibes are configurable via `change_vibe.vibes`.


why is this change_vibe.vibes, maybe just vibes?

relh · 2025-12-23T16:32:25Z

packages/mettagrid/docs/actions.md

 - `change_vibe_neutral`

-> **Note**: The number of available vibes is configurable via `change_vibe.number_of_vibes`.
+> **Note**: The available vibes are configurable via `change_vibe.vibes`.


why is this change_vibe.vibes, maybe just vibes?

relh · 2025-12-23T16:33:09Z

packages/mettagrid/python/src/mettagrid/config/mettagrid_c_config.py

            config_dict["obs"] = config_dict["obs"].copy()
            config_dict["obs"].pop("features", None)
-        # Keep vibe_names in sync with number_of_vibes; favor the explicit count.
+        # Keep vibe_names in sync with vibes; favor the vibes list.
        config_dict.pop("vibe_names", None)
-        change_vibe_cfg = config_dict.setdefault("actions", {}).setdefault("change_vibe", {})
-        change_vibe_cfg["number_of_vibes"] = change_vibe_cfg.get("number_of_vibes") or len(VIBES)
        game_config = GameConfig(**config_dict)


this seems fine? I dont know if we need older configs, maybe just older policies (maybe)

relh · 2025-12-23T16:33:33Z

packages/mettagrid/python/src/mettagrid/demo.py

    # Enable change_vibe for GUI control, but create a policy config without it for random actions
    cfg.game.actions.change_vibe.enabled = True
-    cfg.game.actions.change_vibe.number_of_vibes = 10
+    from mettagrid.config.vibes import VIBES as ALL_VIBES


this is kind of ugly can this import be at the top?

graphite-app · 2025-12-24T03:12:05Z

Merge activity

Dec 24, 3:12 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

daveey mentioned this pull request Dec 22, 2025

Rename cog_arena.py to cogsguard.py and remove unused imports #4477

Open

daveey changed the title cp Replace number_of_vibes with explicit vibes list in change_vibe action config Dec 22, 2025

daveey marked this pull request as ready for review December 22, 2025 18:24

github-actions bot assigned daveey Dec 22, 2025

daveey requested a review from relh December 22, 2025 18:25

daveey assigned relh and unassigned daveey Dec 22, 2025

chatgpt-codex-connector bot reviewed Dec 22, 2025

View reviewed changes

daveey changed the base branch from daveey-resource-limit to graphite-base/4489 December 23, 2025 04:18

daveey force-pushed the daveey-fix-vibes branch from 9db6bf4 to a60b26a Compare December 23, 2025 04:18

daveey force-pushed the graphite-base/4489 branch from f4f2626 to ef5f7f2 Compare December 23, 2025 04:18

daveey changed the base branch from graphite-base/4489 to daveey-inventory-config December 23, 2025 04:18

daveey force-pushed the daveey-fix-vibes branch from a60b26a to 15f6923 Compare December 23, 2025 04:40

daveey force-pushed the daveey-inventory-config branch from ef5f7f2 to 0fdcc0b Compare December 23, 2025 04:40

relh approved these changes Dec 23, 2025

View reviewed changes

Base automatically changed from daveey-inventory-config to main December 24, 2025 03:09

cp

4773bb1

daveey force-pushed the daveey-fix-vibes branch from 15f6923 to 4773bb1 Compare December 24, 2025 03:11

daveey added this pull request to the merge queue Dec 24, 2025

Merged via the queue into main with commit 6cefbf1 Dec 24, 2025
13 checks passed

daveey deleted the daveey-fix-vibes branch December 24, 2025 03:25

Replace number_of_vibes with explicit vibes list in change_vibe action config #4489

Replace number_of_vibes with explicit vibes list in change_vibe action config #4489

Uh oh!

Conversation

daveey commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TL;DR

What changed?

How to test?

Why make this change?

Uh oh!

daveey commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

relh left a comment

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

relh Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Dec 24, 2025

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daveey commented Dec 22, 2025 •

edited

Loading

daveey commented Dec 22, 2025 •

edited

Loading