-
Notifications
You must be signed in to change notification settings - Fork 48
Add observer_agent_id parameter to obs_features method #4384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
84b9460 to
fcb51af
Compare
e49ff8d to
eba9b0b
Compare
e593c79 to
901179e
Compare
eba9b0b to
4d24ad8
Compare
ffc9b85 to
96b9c61
Compare
f97ab21 to
e110801
Compare
e110801 to
0d94584
Compare
0426db2 to
517611f
Compare
| bool onUse(Agent& actor, ActionArg arg) override; | ||
|
|
||
| std::vector<PartialObservationToken> obs_features() const override; | ||
| std::vector<PartialObservationToken> obs_features(unsigned int observer_agent_id = UINT_MAX) const override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line causes CI to fail because the method signature with the new 'observer_agent_id' parameter doesn't match the base class 'GridObject' method signature. The base class 'GridObject' needs to be updated to have the same method signature: 'virtual std::vector obs_features(unsigned int observer_agent_id = UINT_MAX) const;'
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| virtual std::vector<PartialObservationToken> obs_features( | ||
| unsigned int /*observer_agent_id*/ = UINT_MAX) const override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines cause CI to fail because the method signature with the new 'observer_agent_id' parameter doesn't match the base class 'GridObject' method signature. The base class needs to be updated to include this parameter.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| virtual std::vector<PartialObservationToken> obs_features( | ||
| unsigned int /*observer_agent_id*/ = UINT_MAX) const override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines cause CI to fail because the method signature with the new 'observer_agent_id' parameter doesn't match the base class 'GridObject' method signature. The base class needs to be updated to include this parameter.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
0d94584 to
d78fb2a
Compare
517611f to
faecf5e
Compare
| } | ||
|
|
||
| std::vector<PartialObservationToken> obs_features() const override { | ||
| std::vector<PartialObservationToken> obs_features(unsigned int /*observer_agent_id*/ = UINT_MAX) const override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line causes a compilation error because the method signature with the new parameter (observer_agent_id) doesn't match the base class method signature. Either update the base class method to include this parameter or remove the 'override' keyword.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
faecf5e to
b2070f0
Compare
70f1053 to
7d7cdb8
Compare
5eec38a to
c967a0e
Compare
2e25324 to
ffe799b
Compare
b2a9974 to
c8abee8
Compare
ffe799b to
607176c
Compare
c8abee8 to
9337a11
Compare
607176c to
1150cd8
Compare
1150cd8 to
7cb4a85
Compare
9337a11 to
6f4aeba
Compare
7cb4a85 to
cf0a388
Compare
6f4aeba to
7c9ce32
Compare
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |

Adds dynamic pricing to assembler protocols
get_cost_multiplier()method to calculate the appropriate price multiplier based on activation countactivation_countcounter