feat: run cogames smoke test from source code in child repo #4523
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - uses: actions/checkout@v4 | ||
| with: | ||
| repository: Metta-AI/cogames | ||
| # For tag pushes: use the tag name (e.g., cogames-v1.2.3) | ||
| # For manual dispatch: use main branch (since arbitrary branches aren't in child repo) | ||
| ref: ${{ startsWith(github.ref, 'refs/tags/') && github.ref_name || 'main' }} |
There was a problem hiding this comment.
The test job now checks out Metta-AI/cogames (lines 63–68), but the wait-for-mettagrid job still extracts the required mettagrid version from packages/cogames/pyproject.toml in this repo (lines 102–107). If the child repo’s dependency pin diverges from the monorepo’s copy, the workflow may wait for the wrong version (or not wait at all), causing intermittent install failures or false confidence. This mismatch is introduced by the new checkout of the child repo without updating the wait step’s source of truth.
Useful? React with 👍 / 👎.
| - name: Run tests | ||
| run: | | ||
| # Run from clean directory - no metta/ or other repo packages accessible | ||
| pytest tests/ -v |
There was a problem hiding this comment.
Running pytest tests/ -v from the repository root after pip install . means Python will import from the working tree first (cwd is at the front of sys.path). This can mask packaging regressions (e.g., missing package data, incorrect package includes, or build-time generated files) because the tests may exercise the source tree instead of the installed distribution. The previous isolation step avoided this; the new flow no longer validates that the install artifact is actually runnable.
Useful? React with 👍 / 👎.
yatharth
changed the base branch from
yatharth/metta-publish-push-tags-to-child-repo
to
graphite-base/4523
yatharth
force-pushed
the
yatharth/cogames-smoketest-from-child-repo
branch
from
cdbd915 to
f859d89
Compare
yatharth
changed the base branch from
graphite-base/4523
to
yatharth/cogames-release-order
Prompted by nishad's comment on #4423.
(example of successful run)